414 Commits (b9ce297ea97bdc68ce8f9fd17939d7d5f3625343)

Author	SHA1	Message	Date
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976) ... * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods 5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190) * turn scope classes into modules	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935) ... * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit d93ff52a27. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code ... Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	5a7176e6e1	Fix/search for projects (#8815) ... * fix searching for projects * only provide search options active in the project	4 years ago
ulferts	50daff5062	Fix/archived projects via api (#8625) ... * minor code cleanup * allow access to archived projects via api for admins The visibility check will not work in this case as no permission is active on archived projects. We therefore need to return all projects for admins at least	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Henriette Darge	b7ab9483ed	Remove too much spaces from the project name before saving it. Otherwise the spaces will cause problems later, e.g when trying to delete the project	4 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
ulferts	495dfaa92c	ensure base scope for variable	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	c2b5d38b23	avoid eager loading magic	5 years ago
ulferts	95fd58cff7	replace order_by_date with order_by_semver_name	5 years ago
ulferts	9c78d48cea	allow args on scope method	5 years ago
ulferts	bd4b59e321	replace backlogs page overriding by cell	5 years ago
ulferts	9eb38b8346	fix assignable version order	5 years ago
ulferts	c8081225f1	fix project tree sorting ... In case the last element is nested, we need to sort all ancestor levels before returning the projects. Otherwise, only the root layer is sorted.	5 years ago
ulferts	0258e04223	fix assignable version order	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	7d4a4a19e7	use join table for storing activites active in project	5 years ago
ulferts	c96c5b89d5	only require copy_project permission to show button	5 years ago
ulferts	9bf1ccb13a	fix project acts_as_event url	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
ulferts	05ac3af1ee	add projects delete end point to api	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
ulferts	7cca2631b0	add projects create form end point to api	5 years ago
ulferts	f5168bed61	mark TODOs in project model	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
Oliver Günther	693bd7760a	Replace deprecated `update_attribute` with `update` ... `update_attributes` was deprecated in Rails 6	5 years ago
ulferts	e7263fcedb	migrate to rails 6.0.0	5 years ago
ulferts	a841298a31	fix copying projects without members ... When the members are not copied along, assignee, responsible and user cf´s need to be assigned nil	5 years ago
ulferts	cc41884048	add schema to project api and complete project resource	5 years ago
ulferts	f1142c6654	move AccessControl into OpenProject namespace	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	c5994d3b9b	Rename Boards to Forums	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date ... https://community.openproject.com/wp/28446	6 years ago
Oliver Günther	b08a5874f5	Remove project responsible and type	6 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	f5c5e588da	Remove level_list from protected routes ... Is enforced through format: html instead [ci skip]	7 years ago
Jens Ulferts	baa7e99d1d	cleanup timelines data	7 years ago
Oliver Günther	a0150fffa0	Remove timelines	7 years ago
Jens Ulferts	503e3e09b4	show hierarchy icons when project before is ancestor	7 years ago
Wieland Lindenthal	e12554203b	Fix: Other parts of the code relied on short_descriptions too so readded it to the model	7 years ago
Wieland Lindenthal	9edc28e18c	Refactor table cell content	7 years ago