openproject

Commit Graph

Author	SHA1	Message	Date
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16720d2d7c	Rework DeletedUser.first to avoid stack overflow `.find_or_create_by` will call `.first`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6be62329c	Merge branch 'release/4.3' into feature/rails4 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	3be26b747d	Merge pull request #3193 from myabc/feature/rubocop-semantic-blocks Conflicts: Gemfile.lock Note that this adds BUNDLED_WITH to your Gemfile.lock, in case this line gets lost when executing bundle, make sure your local version of bundler is updated first ;-)	9 years ago
Alex Coles	cb81a4afab	Fix for .js.erb preventing asset precompilation Handle empty `Setting.default_language`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	56ce95aa7a	Bump bundled Rubocop to latest ~> 0.32 [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	580735780f	Merge pull request #3165 from vcostin/feature/20580-errors-and-notifications	9 years ago
Jens Ulferts	5765756684	Merge branch 'release/4.3' into feature/rails4	9 years ago
Jens Ulferts	2b99783db4	Merge branch 'release/4.2' into release/4.3	9 years ago
Alex Coles	dd9f346544	Merge pull request #3198 from ulferts/fix/karma_run update webpack to avoid karma fails	9 years ago
Jens Ulferts	a5efb4dba5	update webpack to avoid karma fails	9 years ago
ulferts	2eccc81653	Merge pull request #3192 from NobodysNightmare/feature/show_dates_in_mail include missing attributes in mails	9 years ago
Vadim Costin	8e67407ce7	remove unused variables	9 years ago
Alex Coles	7412f8b103	Merge branch 'release/4.3' into feature/rails4	9 years ago
Jan Sandbrink	0c3562ce49	fix whitespacing in '_issue_details.text.erb' empty lines and indentation used for code formatting is immediately visible in the resulting output. I tried to employ some special rules to at least allow for usage of indentation.	9 years ago
Azure7111	e2c16ac0b2	Merge pull request #3189 from NobodysNightmare/feature/change_status_during_move fix changing status during WP move/copy	9 years ago
Alex Coles	b838da8b83	Tell Rubocop to enforce semantic block delimiters N.B. This is a new feature of Rubocop 0.30.0: https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md > The `semantic` style enforces braces around functional blocks, where > the primary purpose of the block is to return a value and do..end > for procedural blocks, where the primary purpose of the block is its > side-effects. Hound CI currently uses Rubocop 0.29.0. To ensure Hound does not flag our semantic block style, we need to keep the `Blocks` cop config in our `.rubocop.yml` until they upgrade. [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Vadim Costin	b09740ca3e	change default notiffication message style	9 years ago
Jan Sandbrink	c775274707	include missing attributes in mails	9 years ago
Jan Sandbrink	05ecd67429	Merge branch 'release/4.2' into release/4.3 Conflicts: lib/api/v3/errors/error_representer.rb	9 years ago
Jan Sandbrink	2ec1910f20	Merge PR #3030 into release/4.2	9 years ago
Jan Sandbrink	1eb648fc7c	Merge branch 'release/4.2' into release/4.3	9 years ago
Jan Sandbrink	96d0cf9462	fix moving of WPs without specifying a status attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Jan Sandbrink	95f5d58185	Merge pull request #3187 from floriank/fix/20569-assignee-responsible-unsetting [20569] Make unsetting assignee and responsible possible again	9 years ago
Jens Ulferts	1fc2661375	another safeguard for the inplace edit spec	9 years ago
Alex Coles	5bd958453f	Merge branch 'dev' into feature/rails4	9 years ago
Alex Coles	61d77c721b	Fix TextFormatting#format_text specs w/requests * Make intent slightly clearer with a shared context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	44b531b349	Merge branch 'release/4.2' into dev	9 years ago
Alex Coles	31b12a6ead	Remove no-args #url_for call from TextFormatting `#url_for` with no args raises `ActionController::UrlGenerationError`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Evghenii Barhatov	a609680483	Allow raising exceptions from notification jobs	9 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving apparently the status_id param was set to expect an array of values while being moved in this commit: `d7f399ab8d` Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	9 years ago
Jan Sandbrink	cfda86b2bf	Merge pull request #3171 from floriank/fix/20544-ungrouping-impossible [20544] Add an empty option to grouping menu	9 years ago
Florian Kraft	f23c946fa3	Merge pull request #3183 from ulferts/feature/new_tab_on_help_link_click open help in new tab	9 years ago
ulferts	0056a631fc	Merge pull request #3184 from floriank/fix/20628-change-url-in-footer [20628] Change OpenProject URL url in footer	9 years ago
Florian Kraft	396ef0b024	use clear value label [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	15ece51581	add the no value label to linked embedded fields Also, use a different label for the clear option Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	06645249a2	next try to get inplace edit specs stable	9 years ago
Alex Coles	30aa2067d9	Merge branch 'dev' into feature/rails4	9 years ago
Jan Sandbrink	a79a30c45d	Merge pull request #3181 from oliverguenther/fix/search_form_browser_consistency Fix unstable focusing of search form in Firefox	9 years ago
Oliver Günther	8a97f71b65	[ci skip] Fix unstable focusing of search form in Firefox This should fix the bug introduced by https://github.com/opf/openproject/pull/3156 and reported in https://community.openproject.org/work_packages/20540#note-11 It seems that Firefox has a bug that it does not tolerate a focus event trigged in the few ms after focus has been gained on another element. I was able to reproduce this behavior in Firefox for focus of {0,10} ms. It does not seem to block the focus event after a 20ms delay. Related: http://stackoverflow.com/questions/704679 Relevant work package: https://community.openproject.org/work_packages/20540	9 years ago
Florian Kraft	49b2b25dd4	Merge pull request #3180 from myabc/fix/legacy-specs-rake Fix running of legacy specs with Rake	9 years ago
Alexander Bach	b3a8e0187e	Merge pull request #3115 from opf/fix/specify_watchers_link	9 years ago
Jens Ulferts	01f62ce9d6	open help in new tab Please note that the implementation of what to do on target='_blank' is browser specific but they should open up a new tab. Alternatively they can open up a new window. The specification can be found here: http://www.w3.org/html/wg/drafts/html/master/browsers.html#browsing-context-names	9 years ago
Florian Kraft	67588eed91	change default value for footer link [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	5d71902500	typo [ci skip]	9 years ago
Jan Sandbrink	baaf452cbd	style [ci skip]	9 years ago
Jan Sandbrink	e7a2b936b7	clarify words [ci skip]	9 years ago

1 2 3 4 5 ...

22256 Commits (ce9370102983d8e4cd6a75a62114b16a7f7b448e) All Branches Search

22256 Commits (ce9370102983d8e4cd6a75a62114b16a7f7b448e)

All Branches