850 Commits (d96d47d4fba9f9e57be316b5b59a5b82feca183f)

Author	SHA1	Message	Date
Christophe Bliard	47a297daae	Fix argument alignment since f08bea3467 (#10129) ... * Fix argument alignment since f08bea3467 The FactoryBot.* prefix has been removed in f08bea3467. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it. * do not fix alignments for modules/*/spec yet hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors	3 years ago
ulferts	e4cbf6deee	replace usage of OpenStruct	3 years ago
ulferts	a3fc906ff8	ensure using .create for cf representer initialization	3 years ago
Oliver Günther	49b796541c	Add more pageSize=-1 to filter dependencies	3 years ago
Oliver Günther	43891b23bb	Add a separate setting for max API size	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago
Oliver Günther	38ee719c26	Add pageSize=-1 to dynamic form components (#10048) ... * Add pageSize=1000 to dynamic form components * revive magic number for page size Providing -1 will result in the maximum page size being chosen. The magic number used to be 0 but that conflicts with the use case of really wanting no results to be included, e.g. when only interested in the total number or sums Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
ulferts	633fa3c8b8	add ancestor list to project resource	3 years ago
ulferts	fe06d885db	paginate relations collection ... The response to /api/v3/relations is paginated. The response to /api/v3/work_packages/:id/relations is not yet paginated as: * The front end currently does not handle pagination * The expected amount of relations returned is lower as it is limited to the relations from/to the one work package.	3 years ago
ulferts	816057e65e	allow suppressing notifications on member create/update	3 years ago
ulferts	0fe90c21a7	rework hidden/starred of queries ... The MenuItems::QueryMenuItems class used to map the `starred` state is replaced by a simple boolean flag. The hidden flag is removed (but still readable) as the concept of `View`s completely replaces it.	3 years ago
ulferts	b34310ee48	add POST /api/v3/views/team_planner	3 years ago
ulferts	909635fc15	remove projection paths	3 years ago
Wieland Lindenthal	c0faea6cbf	Add attribute "name" to ViewRepresenter	3 years ago
ulferts	3f9cfdf732	static create endpoint for Views::WorkPackagesTable	3 years ago
ulferts	da00b6bac8	linting spec file	3 years ago
ulferts	60dc2750b1	show and index actions for views	3 years ago
ulferts	01bbcc56a2	include projection in query representer	3 years ago
Oliver Günther	9ec1e05891	Fix counting on multiple columns for project	3 years ago
Oliver Günther	f039fc8333	Add representation formats to project API	3 years ago
ulferts	7040d2bc53	alter permission for custom fields in even more wp representers	3 years ago
ulferts	edfc30365b	adapt permission check in work package representers	3 years ago
ulferts	f89f19dffc	use resouce based routing	3 years ago
ulferts	ebcf9138cc	introduce separate permission for selecting custom fields	3 years ago
Oliver Günther	42b314bb97	Allow setting only one date, assumed to be first=last date	3 years ago
Oliver Günther	31f9d05552	Remove details from notifications API ... https://community.openproject.org/work_packages/39079	3 years ago
ulferts	92cc5a603e	remove method that used to convert to tzinfo	3 years ago
Oliver Günther	320ceaf670	Fix specs	3 years ago
Oliver Günther	2d6289d8a7	Replace all option in parsing representer with 'real' setting	3 years ago
Oliver Günther	8dec991d01	Remove channel from non-wp PR	3 years ago
Oliver Günther	e3913e61e4	Remove read_mail, reason_mail, reason_mail_digest	3 years ago
Oliver Günther	4abc005ff2	Replace property + spec with iterator over all_settings	3 years ago
ulferts	b3b3b80cb9	eager loading for notifications and activities ... Associations that cannot be loaded via rails` eager loading are eager loaded by hand: * The 'data' association of journals * The 'predecessor' association of journals * The 'journable' association of journals * The 'resource' association of notifiations Since the notifications and the activities index api have a similar data structure, notifications can reuse the eager loading of activities. Does not include any optimization for the rendering of the details as of now since the structure of the details is still subject to change.	3 years ago
Oliver Günther	92954efc92	Fix attachment parsing representer spec	3 years ago
Oliver Günther	e5dec2dc31	Add notification group_by for projects with transformed keys	3 years ago
Oliver Günther	e9ac166593	Add notification api specs for grouping	3 years ago
ulferts	57cfa51d19	accept HH:MM as valid times for the reminders	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	1f024e5796	remove no_self_notified user preference	3 years ago
ulferts	2a6ab15101	add work package scheduled notification setting	3 years ago
ulferts	09f1a37f3c	add work package prioritized notification setting	3 years ago
ulferts	61357f5091	add work package processed notification setting	3 years ago
ulferts	a1074bcb93	add work package created notification setting	3 years ago
ulferts	f246346014	add work package commented notification setting	3 years ago
Oliver Günther	a87031982b	[38077] Skip rendering initial journal details in notifications ... https://community.openproject.org/wp/38077	3 years ago
ulferts	75bb809ad6	Feature/1899 send daily email summaries (#9430) ... * email digests * use time for notification digest setting * safeguard against empty digest	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431) ... * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
ulferts	261b0fa5c3	add bulk read/unread enpoint for notifications	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399) ... * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit e29dced646 Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit 1a45c26c1a Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit 0ea21e90c1 Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in 0d6c0b6bc7 * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396) ... * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago