openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	b6ee21efb5	Merge branch 'release/4.1' into release/4.2	9 years ago
Oliver Günther	af59a5403d	Merge branch 'origin/release/4.0' into release/4.1 Conflicts: Gemfile.lock lib/open_project/version.rb	9 years ago
Oliver Günther	db534a1263	Merge pull request #3264 from ulferts/fix/bump_rack_session bump rack to 1.4.7	9 years ago
Jan Sandbrink	3a87b269fa	allow to fetch aggregated journals for a journable - this should be faster (or at least easier to optimize) than applying a WHERE to the whole scope - also starting to diverge from using classic ActiveRecord in aggregated journals	9 years ago
Oliver Günther	3f347fdc25	Refactor attribute-groups to use -toggleable modifier instead	9 years ago
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	fb654d0afa	Correct for review - Switch to styled_form and remove highlight from button - Fix permanently typo	9 years ago
Jan Sandbrink	db98953d4f	Merge pull request #3265 from oliverguenther/feature/improve-web-service-wording Improve settings for mail, sys web services to improve comprehension.	9 years ago
Oliver Günther	9d88ed6027	Remove remark regarding subversion.	9 years ago
Oliver Günther	35c78a6acc	Remove superfluous JS remote select.	9 years ago
Oliver Günther	ddfb07659a	Added description to configuration.yml.example. This changes the configuration example to the new format, which allows to enable managed repositories for a custom selection of vendors.	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	c63b9c7a08	Frontend refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user.	9 years ago
Oliver Günther	3377696563	Began frontend feature specs	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	2ce4646346	Reverted implied annotate bugfix which raised more questions Annotation syntax highlighting was broken and I fixed it, this commit reverts the changes, which will be properly re-addressed in the separated PR: https://github.com/opf/openproject/pull/3250	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	15d026081b	Convert repository fixtures for compatibility. Travis build system still runs Ubuntu 12.04., which includes subversion 1.6.17. Rather than introducing a whole new PPA to travis, this commit converts the new subversion test fixture to pre-1.6 compatibility. Also, OSX's bsdtar uses `._*` member files for special meaning, which will lead to filesystem specs reporting incorrect size on a Linux system. To circumvent this, filesystem fixture has been re-packed with `COPYFILE_DISABLE=1` (c.f., http://superuser.com/questions/61185)	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Oliver Günther	1618c80924	Use severe notification for project destroy dialog The current project `destroy_info` style is inconsistent with the styleguide, as it uses a `notification` (used for one-line notifications only) instead of a warning notification box. This commit switches this dialog to the notification-box with warning parameter and suggests to additionaly use the new `-severe` switch for warnings due the potential ramifications this action has. Using `-severe` also makes it compatible with the upcoming repository destroy_info dialog, which also uses this dialog when local data is to be deleted outside OpenProject.	9 years ago
Florian Kraft	4a155d267e	Merge pull request #3266 from oliverguenther/feature/severe_warnings_style [ci skip] Allow notification-box.warning to be severe without being a…	9 years ago
Oliver Günther	a7f7f925f8	[ci skip] Allow notification-box.warning to be severe without being an error. In the review of https://github.com/opf/openproject/pull/3196, a notification box with error style was used to communicate a warning prior to repository deletion with severe consequences (removal of files outside OpenProject). This commit suggests to add a `-severe` switch to warning notifications to signal such a severe decision while NOT being an error. The implementation re-uses the error colors (as red is often used to communicate severe warnings - cf. GitHub danger zone, Bootstrap styles). I envision this notification to be used in other aspects of the application, with at least project destroy_info to be of the same severity that I argue this to be included in the core. Relevant work package: https://community.openproject.org/work_packages/20999	9 years ago
Oliver Günther	933c553ba9	Improve settings for mail, sys web services to improve comprehension. This commit provides: - Improved labels for mail_handler and sys api to spell out `WS`. - Added instruction below the both checkboxes with a brief introduction on what this setting actually does.	9 years ago
Jens Ulferts	87646af3fa	bump rack to 1.4.7 rack 1.4.6 contains a bug counting every multipart against the file multipart limit `bf5bd20c38`	9 years ago
Jan Sandbrink	a8ab1024b5	clarify explanations typos, wording and stuff	9 years ago
Jan Sandbrink	5f06a8900d	better PSQL compatibility for aggregated journals	9 years ago
Jan Sandbrink	f02b32faad	override :initial? for AggregatedJournal the simple approach of looking at the version number does not work, because aggregated journals can have gaps in their versions (and there might be no version 1)	9 years ago
Jan Sandbrink	a5152e9875	use the actual setting for the aggregation time	9 years ago
Jan Sandbrink	88169a46de	expose id of "master" as notes_id - make spec assertions more detailed by comparing all the attributes	9 years ago
Jan Sandbrink	3c3b03bbcc	make SQL compliant for both MySQL and PSQL	9 years ago
Jan Sandbrink	405aa2d524	add PostgreSQL-compatible group numbering	9 years ago
Jan Sandbrink	e346909b36	add more specs for aggregated journals	9 years ago
Jan Sandbrink	3b7b0ec289	Enhance AggregatedJournals to correctly merge journals with notes Aggregation should now follow the rules previously defined for merging journals (see code comments). Jens (@ulferts) and I developed the SQL for this. I hope the explanatory comments make it a quite readable SQL experience.	9 years ago
Jan Sandbrink	8bab9a3d22	add specs for not aggregating comments	9 years ago
Jan Sandbrink	ddbc8a4ba7	remove obsoleted helper	9 years ago
Jan Sandbrink	5ed1ff28c1	styling	9 years ago
Jan Sandbrink	953ad6d15f	change aggregated_journals on AaJ to be a method - a "real" relation involves cascading updates that are not intended for _aggregated_ journals	9 years ago
Jan Sandbrink	9e9ca84d9c	test non-aggregation after time gap	9 years ago
Jan Sandbrink	885d8d734f	add basic spec for aggregated journals	9 years ago
Jan Sandbrink	ec720a0533	make aggregation capable for MySQL and PSQL - also give the time threshold a useful meaning (number of seconds)	9 years ago
Jan Sandbrink	d6533b100c	first spike for aggregatable journals	9 years ago
Jan Sandbrink	a59b361222	remove dead code	9 years ago
Jonas Heinrich	d5299c3ec4	Fixes two incorrect english strings	9 years ago
Jan Sandbrink	0399335a92	Merge pull request #3260 from ulferts/feature/change_default_for_rest_api_enabled change default on rest_api_enabled	9 years ago
Jan Sandbrink	5c5b1c3c46	automatically re-index journals We should now be able to address all inconsistencies that occured before introduction of our new index	9 years ago

1 2 3 4 5 ...

22405 Commits (da9771ae1b1ed757e423ac5a704c24d51e91f107) All Branches Search

22405 Commits (da9771ae1b1ed757e423ac5a704c24d51e91f107)

All Branches