22405 Commits (da9771ae1b1ed757e423ac5a704c24d51e91f107)

 

All Branches   

Search

Author	SHA1	Message	Date
Jens Ulferts	4b0b57b8ef	Merge branch 'release/4.2' into release/4.3	9 years ago
Jens Ulferts	1283305d39	update caypbara and selenium	9 years ago
Jan Sandbrink	fb2efa5909	be more concise!	9 years ago
kgalli	556c23b1ba	Add enable_starttls_auto setting	9 years ago
Florian Kraft	6d11f77df7	Merge pull request #3214 from ulferts/feature/update_protractor ... update protractor	9 years ago
ulferts	377a22c4ec	Merge pull request #3234 from NobodysNightmare/feature/remove_apiv2_access ... Remove access to APIv2 from WP list view	9 years ago
ulferts	fc1d03171d	Merge pull request #3231 from noku/fix/20596_invalid_response_for_api_v2_authentication ... 20596 Fix invalid response for /api/v2/authentication.json	9 years ago
Jan Sandbrink	8f592cccd7	Merge pull request #3239 from ulferts/fix/unclear_status_deletion_string ... changing I18n for error on deleting wp status	9 years ago
Jan Sandbrink	9b9f2f26e8	Merge pull request #3227 from Azure7111/feature/journal_aggregation_setting ... Feature journal aggregation setting	9 years ago
Azure7111	af85e8d603	Fix settings label	9 years ago
Azure7111	f16f916bdd	Fix setting reference	9 years ago
Vadim Costin	299ef4ceda	remove display flex for overlay issue overlay	9 years ago
Jonas Heinrich	936948508a	Updates OpenProject-Translations	9 years ago
ulferts	b26b16bad0	Merge pull request #3233 from NobodysNightmare/feature/fix_update_by ... fix update_by! when not providing notes	9 years ago
Jens Ulferts	008040fbd4	changing I18n for error on deleting wp status	9 years ago
Alexander Bach	83140024e2	Specify setting unit more precisely	9 years ago
Alexander Bach	a084fb06af	Explain mail notification delay	9 years ago
Vadim Costin	376245612e	centred the notification messages and change names of css classes	9 years ago
Vadim Costin	2bba34e9ed	style notifications with zurb app	9 years ago
Jan Sandbrink	1f7485d5bf	fix HTTP 500 in WP form ... - occured when an invalid type was provided by the client	9 years ago
Jan Sandbrink	7e53b9ac04	remove spec expecting german translations ... german translations are not part of OpenProject anymore (they are now provided via Crowdin)	9 years ago
Azure7111	06707f8e56	Merge pull request #3222 from machisuji/fix/x_auth_scheme_legacy_support ... rely on translation of deprecated X-Header-Format to HTTP_X_HEADER_FORMAT	9 years ago
Jan Sandbrink	1b5bb5ba98	use AR errors as mock	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	1ac80edc3c	use common name conversion in linked properties ... some day we could do that for ALL properties...	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children ... - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	0dd77ecb5f	use merge! method of Reform::Contract::Errors ... - this is more concise, but more importantly: - it uses our patched in symbol merging, thereby correctly transferring symbol information	9 years ago
Jan Sandbrink	bc30b28558	extract attribute name conversion into extra class ... - consider special renaming rules for well known attribute names -> currently covering wp attributes and createdAt, updatedAt	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs ... - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	138d3dba29	fix some specs ... - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
Jan Sandbrink	6c9bd3c63f	apply a hack to fix an error	9 years ago
Jan Sandbrink	662f99808a	apply basic attribute name transformations ... those are the ones that were present earlier already. They do not cover the hard cases, where the backend has completely different names form the API	9 years ago
Jan Sandbrink	bd484a9fbe	include punctuation in error locales	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	3e87d10980	fix bogus errors in contracts ... - AR tried to read properties that are undefined on the contract (:error_read_only) - now that we actually use Contract properties the copy-validations stuff started to do things, however: - we already went another path to simultaneously validate contract + model - validation was apparently broken, e.g. though the subject was not empty, there were subject :blank errors	9 years ago
Jan Sandbrink	c586a9cc8c	mock the model in model_contract_spec	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms ... That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	a0e2c26deb	define properties on contract ... Actually it is documented that a :property needs to be defined on the contract (see https://github.com/apotonick/reform#contracts). We just did not do that until now, because it was not neccessary when abusing AR::Errors as hard as we did.	9 years ago
Jan Sandbrink	8f110d8b93	adapt specs to new contract behaviour ... - also refine specs for done-ratio to check for non-fail when not changed - use shared examples for parent properties also in done ratio specs	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts ... - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Jan Sandbrink	eec35308ce	use contract directly in WP create too	9 years ago
Jan Sandbrink	e9059a97ee	style ... [ci skip]	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock ... also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	e5dd8732fc	fix stupid mistakes ... - reference to method by old name - not knowing how to call a super-method	9 years ago
Jan Sandbrink	88d7944bb1	hide error merging behind contract.validate	9 years ago
Jan Sandbrink	e22334a5f6	rename local	9 years ago
Jan Sandbrink	025f3f589e	remove side effect from Validation.create ... I just don't know what the original author thought...	9 years ago
Jan Sandbrink	0b7b4bf329	extract error merging into contract	9 years ago