333 Commits (daa890263efd45d7c431770bb1d2b1cbfdf0d588)

Author	SHA1	Message	Date
Oliver Günther	bd1247d376	Strip notify from frontend ... The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Jens Ulferts	530d837889	fix protractor spec broken by 735b83c ... The execute-on-enter directive was removed in 735b83c. The test should have been adapted then.	9 years ago
Jens Ulferts	63f6a73846	prevent event to be bound to element of first test run	9 years ago
Jens Ulferts	1ef2728d5f	add unit test	9 years ago
Jens Ulferts	735b83cab5	replace execute-on-enter by click-on-keypress	9 years ago
Magdalena Kafka	4b1e0b55a6	Remove toggle all link from wp table	9 years ago
Jens Ulferts	12f8dbf688	Revert "Merge pull request #3661 from furinvader/features/refactoring" ... This reverts commit 64948b19bf, reversing changes made to e5378c54b3.	9 years ago
Jens Ulferts	dbfcfb49b7	Revert "Merge pull request #3646 from furinvader/16364-fullscreen-edit" ... This reverts commit cddeebbf43, reversing changes made to 44ba79e900.	9 years ago
Alex Dik	23a0d6855a	Keep inplace edit values between views ... ... while also keeping empty values [ci skip]	9 years ago
Alex Dik	b422907206	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	13c664371b	Reference field names via newly introduced field object	9 years ago
Alex Dik	0faeeff74c	Refactor inplace-edit directory structure ... [ci skip]	9 years ago
Alex Dik	5dbb78fe79	Replace UI Select with default HTML elements ... [ci skip]	9 years ago
Alex Dik	46bb3540cc	Ask user for confirmation when changing states ... [ci skip]	9 years ago
Alex Dik	8fc31699c9	Disable some ui elements when in edit mode	9 years ago
Alex Dik	5ab24dc7a6	Implement cancel button for fullscreen edit ... Input values are set to their initial values when one restarts editing.	9 years ago
Alex Dik	9ec5cd8ea6	Reset user input when cancel button is used in edit mode	9 years ago
Alex Dik	92009a1dd7	Make user input stay when switching between views	9 years ago
Alex Dik	be5beca5ca	Implement WP-edit save button	9 years ago
Alex Dik	9b290d18f3	Refactor EditableFieldsService and EditPaneController ... Move isActiveField and getPendingFormChanges to EditableFieldsState service.	9 years ago
Alex Dik	7d86b2977c	Disable WP edit buttons for users without update permissions	9 years ago
Alex Dik	b9bf6d0274	Add work package edit actions toolbar (save & cancel) ... Saving the work package does not work as of yet.	9 years ago
Alex Dik	b70f073a73	Implement tests for WP fullscreen editing	9 years ago
Alex Dik	a976579da3	Fix error that prevented protractor from starting ... [ci skip]	9 years ago
Alex Dik	43318dac3f	Allow tests/specs to be located under components/ ... This makes it possible to have tests in the same location as the components they belong to.	9 years ago
Alex Dik	0e5e0dfd38	Refactor HALAPIResource service	9 years ago
Oliver Günther	d3d6cd60ee	Temporarily store promises until they are resolved ... The original commit simply stored promises into the cache, which seemed to work in browsers but failed with karma/PhantomJS. I'm not yet certain why that is, but I wanted to get rid of complex objects in sessionStorage anyway, so this commit does: * temporarily store running promises for a given key * cache the resolved data directly	9 years ago
Oliver Günther	64d5b399c5	Experiment with angular-cache ... One prominent example where we can employ frontend-side caching is the fetching of associated users in activities. For a large number of comments of the same user, that user is retrieved once per activity, which causes a drastic overhead. This commit introduces a simple wrapper around angular-cache to store values in the sessionStorage.	9 years ago
Oliver Günther	d09c91d2f8	Complete translation of done ratio ... Fixes specs broken with a4b672ce22	9 years ago
Alex Dik	74f302b504	Fix missing project scope in routes	9 years ago
Jens Ulferts	0c768829e7	rely on fully qualified uris for HALAPI ... As we should more and more rely on the links provided by the API, it makes less and less sense to construct the urls by ourselves. We can simply use the links, the api offers. There are still a lot of places that construct the uri manually. The HALAPIRessource adds to that manual construction by adding [appBasePath] + /api/v3 to every path provided to it. The callers do now have to care for that. The current callers have been altered so that they do by relying on the PathHelper which should reduce the places in which uris are constructed.	9 years ago
Stefan Botzenhart	4eaf12bf10	Fix or disable protractor specs	9 years ago
Alex Dik	e0931a496f	Fix karma specs for activity directives	9 years ago
Alex Dik	c5067f1299	Fix wp list controller test for setting projectIdentifier	9 years ago
Oliver Günther	628d95ae8a	Fix protractor specs	9 years ago
Oliver Günther	024754830f	Avoid references to overview tab and details which no longer exists	9 years ago
Tim Habermaas	99b7a31413	Fix attachments directive test after rebase. ... Stub the `links` attribute of a work package which is usually present when using the API.	9 years ago
Tim Habermaas	4cde439694	[WIP] Fix protractor specs.	9 years ago
Tim Habermaas	0be7cc7d24	Fix karma specs.	9 years ago
Tim Habermaas	7059dcc1a6	[WIP] [skip ci] fix some karma specs	9 years ago
Henriette Dinger	64be47f600	Fix broken spec	9 years ago
Henriette Dinger	ee31ccdccf	Exchange classes and labels: delete, remove	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Jens Ulferts	c26773e5f8	split method to avoid boolean flag	9 years ago
Jens Ulferts	52b1f75d5c	remove no longer required attachment directives	9 years ago
Jens Ulferts	2d081b97fb	filter directories before uploading ... Uploading directories is not possible. When dragging a directory to the dropzone, the direcory is flattened so that the files in the directory will be accepted, but the directory itself is ignored.	9 years ago