openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169 ) * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
schuemann	b577ed62ec	[#36518 ] respect hide mail preference in member list (#9072 ) * [#36518] respect hide mail preference in member list The member table should hide the email address if the user has the "Hide my email address" box checked in their profile. * [#36518] respect hide mail preference in member list Updating feature spec * Updating feature spec * Add transient preference object * Include preference to avoid n+1 query * Correctly pass user_id= to super * Fix now invalid usages of user_preference factory * Rewrite attribute check to include user attribute_present? does not return true for relations such as user_id * Only save a preference if the transient factory got used Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	f0cf90d7e1	Fix the rails cell not using the content_tag helper of ActionView with escaping (#9067 ) * fixes show links for project members * Properly escapes the name. The cells gem does not escape strings unlike rails * Fixes the case statement for links and includes the link for placeholder users * Fix escaping of content_tag in rails cell and add spec for that Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	1008a2c4c1	[32274] Show the original roles for admins https://community.openproject.com/wp/32274	5 years ago
ulferts	5b217ec039	prevent multiple clicks on member destroy link	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	67b3e575ce	[28036] Give admin all roles in a project https://community.openproject.com/wp/28036	6 years ago
Oliver Günther	70e2393f6a	[29611] Remove members group sort by https://community.openproject.com/wp/29611	6 years ago
Oliver Günther	91e884d41c	[29334] Fix alias name for group sorting https://community.openproject.com/wp/29334	6 years ago
MarcoSpittka	245ef7b60c	changed mysql alias Update table_cell.rb - changed mysql alias groups for upwards compatibility	6 years ago
Oliver Günther	1b29f38c06	Fix most of the specs does not yet address the CSP problem of user memberships	7 years ago
Henriette Dinger	3529e85225	Add close icon to filter sections (#6004 ) [ci skip]	7 years ago
Oliver Günther	eb2c6ab47f	[26101] Fix filter cell path (#5851 ) https://community.openproject.com/wp/26101 [ci skip]	7 years ago
ulferts	daa1a4d4b7	fixes filtering members by group (#5800 ) additionally fixes: * with "all" selected, all members are shown, not only those being active, invited or registered * with "locked" selected, locked users are now displayed. * the Project#members_principals associations lacked the `references` method which lead to the users table being undefined in the resulting query. In order to achive the bug fixes, the member filtering is now based on the query engine also used for users, queries, work_packages, ... As a lot of the members filters are very similar to user filters (in fact, a lot of the members filter work on the users model), those filters are shared via modules. [ci skip]	7 years ago
Oliver Günther	bb88d38ff0	[25979] Toggle membership form elements and compile response … (#5802 ) * [25979] Toggle membership form elements and compile response This fixes two issues: 1. Toggles the form elements with a class selector so the impermanent memberships plugin can extend it. 2. Compiles the response html so subsequent datepickers are shown https://community.openproject.com/wp/25979 * Apply the same fix to the member cell [ci skip]	7 years ago
Oliver Günther	441279e4a9	Fix icons in member rows	8 years ago
Oliver Günther	e48e5449c6	Fix user filter cell being hidden by default	8 years ago
Markus Kahl	02901cc52c	override members user filter to always show all	8 years ago
Markus Kahl	5e5f4e7107	link first and last names to user page	8 years ago
Jens Ulferts	9c439f6820	limit members count to members	8 years ago
Markus Kahl	f57a939f30	always join groups to support group filter	8 years ago
Markus Kahl	492bbcd068	refactor user filter to allow impermanent memberships integration	8 years ago
Markus Kahl	6bb59c69d7	pass plain columns to sort_collection to be able to join conditionally	8 years ago
Markus Kahl	a230ce5e23	further simple member screen refactoring to allow plugins to integrate	8 years ago
Markus Kahl	5a6f297728	moved row cell out of table namespace to avoid conflict with costs plugin	8 years ago
Markus Kahl	e9d126f340	avoid ambiguity when ordering by type	8 years ago
Markus Kahl	d9101386f6	final rubocop remarks	8 years ago
Markus Kahl	35c5a69e6c	rubocop remarks	8 years ago
Markus Kahl	fa5409ba13	fixed specs mostly	8 years ago
Markus Kahl	b55b682805	enhanced member screen; members and user table refactoring using cells	8 years ago

33 Commits (dd703bcb2d5e7148644023a701749f39950a79d0)