openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Markus Kahl	5e795a844a	remove unnecessary redefinition of order_by_name scope	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	c2b5d38b23	avoid eager loading magic	5 years ago
ulferts	95fd58cff7	replace order_by_date with order_by_semver_name	5 years ago
ulferts	e7359bcd94	have scoped methods available in model class	5 years ago
ulferts	9fa02860f9	introduce semver name sorting scope	5 years ago
Oliver Günther	18e4ed1a9a	Change case insensitive validations to false	5 years ago
Oliver Günther	fa33b8c296	[32296] Also ensure versions are sorted by name If versions are not sorted by date, the default work_packages.id sort will break up grouped versions if they have no date. https://community.openproject.com/wp/32296	5 years ago
Oliver Günther	fa25c0ec21	Remove magic start_date applied to version, but not saved to DB [ci skip]	5 years ago
Oliver Günther	c18ae83b9e	Sort versions in roadmap in the same fashion	5 years ago
Oliver Günther	f4f1e98b20	[32156] Use backlogs sorting of versions date for work packages - Adds a null_handling option to the property columns to allow `NULLS FIRST/LAST` to be handled - Adds a query specific SortCriteria that can work with null_handling - Fixes sorting of allowed_versions to reuse that sort order https://community.openproject.com/wp/32156	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	e7263fcedb	migrate to rails 6.0.0	5 years ago
ulferts	1850622f20	Feature/versions api update (#7299 ) Feature/versions api update [ci skip]	6 years ago
Oliver Günther	5de0b9a2d8	Go through brakeman warnings	6 years ago
Oliver Günther	ae8db4011a	Fix more deprecations	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date https://community.openproject.com/wp/28446	6 years ago
Jens Ulferts	0b7e192a5d	adapt to changes to AR::Dirty	7 years ago
Jens Ulferts	486046681d	replace deprecated references to attribute_was/changed	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	a1812699f0	validate actions	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	89ac5789c7	Replace scopes with already defined names The activerecord scope helpers output a warning when a scope's name already exists in the module's method chain. E.g., `Kernel#open` is overridden by some of the scopes, but that always results in a warning. A better way is to explicitly override the method in the model using a class method.	7 years ago
ulferts	cea23ce333	Fix/sort version filter options (#5630 ) * have version filter options ordered by name * Fixes filter options on global queries (returned types instead of versions) * Adds the name order to be available generally * code prettification [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params We no longer need attr_accessible.	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jens Ulferts	c46d9e4b4d	sort versions throughout the rails world	9 years ago
Alex Coles	29d9814347	Prefer Project.allowed_to to .allowed_to_condition Use `ActiveRecord::Relation#merge` to merge scopes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8afb27578f	Add missing explicit join reference in Version Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fb8dfed1a4	Minor indent fix in Version for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	1c8fced609	adds scope of projects on version	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Jens Ulferts	8b3a1cf47d	rewrite scopes to avoid 'conditions' 'conditions don't seem to merge any more	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Mihail Maxacov	228a216dcb	fix wp details pane project name not displayed in front of inherited version	10 years ago
Jens Ulferts	9086d3b1ce	adds scope for retreiving system shared versions	10 years ago

1 2 3

114 Commits (de0f155c94e44eafd2b69fe8ea5f35d23f0fe2b4)