543 Commits (e8589bd199fc67d4d5b183b19acd8634a61a0b02)

Author	SHA1	Message	Date
Oliver Günther	6256e5cd92	Scroll to elements before interacting	7 years ago
Oliver Günther	b15f07ea32	Scroll to element when blocked by overflow ... The details view blocks certain elements of the table, causing clicks to no longer work in newer Firefoxen This is mainly caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1295538	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	b0301d8aae	Another try at the wait time for export_spec (#5945) ... * Another try at the wait time for export_spec * Make invalid_query a single example [ci skip]	7 years ago
Oliver Günther	e69cb8b400	[26375] Don't check the type for unloaded work packages (#5944) ... https://community.openproject.com/wp/26375 [ci skip]	7 years ago
Henriette Dinger	214679adf2	Remove unnecessary label ... [ci skip]	7 years ago
Oliver Günther	93f7e4f7c1	[26338] Allow spaces in matcher for principal mentions (#5930) ... * [26338] Allow spaces in matcher for principal mentions * Bump atwho.js to 1.5.4 and use option 'acceptSpaceBar' [ci skip]	7 years ago
Oliver Günther	2e521a49e3	[26304] Save inline-create and split view together (#5923) ... We only have the one `new` work package and changeset, so we can't handle multiple views creating different work packages. [ci skip]	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897) ... * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again ... The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	7773e62663	[26246] Revert single click opens split view (#5899) ... https://community.openproject.com/wp/26246 [ci skip]	7 years ago
Roman Roelofsen	a666acd15b	Timeline init auto zoom (#5866) ... * Fixed lint errors * fixed code style * WIP timeline init auto zoom * Add timeline auto zoom feature * timeline autozoom: - display toggle state - rearrange toolbar buttons * timeline autozoom: - display toggle state - rearrange toolbar buttons * Add auto-zoom / focus icon * timeline autozoom: - sync auto level with buttons * Fix test [ci skip]	7 years ago
Oliver Günther	f16319bae4	[25280] Implement danger zone for when deleting work packages (#5881) ... Shows a danger zone modal for one or more (bulk) work package deletion requests. For a single work package: * Shows a confirmation for the single work package * Additionally, lists all children if any For multiple work packages: * List of all work packages to be deleted * Children count per work package if any. https://community.openproject.com/wp/25280 [ci skip]	7 years ago
Oliver Günther	5bb83c0c22	[26152] Add loading indicator for initial relations loading ... https://community.openproject.com/wp/26152	7 years ago
Oliver Günther	2aecba00f6	Fix display of start|due date in milestones	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable ... https://community.openproject.com/wp/25999	7 years ago
Oliver Günther	eeb0979926	[25699] Add separate helper class to assign filter values to changeset (#5860) ... [ci skip]	7 years ago
Oliver Günther	645f0ceba9	Minor inline-create timeline styling fixes (#5849) ... * Fix row mirror in timeline * Add bottom to timeline body * Re-enter new timeline row upon rendered [ci skip]	7 years ago
Oliver Günther	09637bd629	[26086] Fix switching from timeline (#5848) ... * [26086] Fix switching from timeline https://community.openproject.com/wp/26086 * Add regression test [ci skip]	7 years ago
Oliver Günther	dbc1e8a848	Fix saving by enter	7 years ago
Oliver Günther	3983c44c16	Add project switch spec	7 years ago
Oliver Günther	7878734e6b	[26006][25518] Replace details icon with context menu, open on first click (#5835) ... * [26006] Replace details icon with context menu * [25518] Open details view on click in table * Show dropdown icons always for mobile * Move context menu column to the right * Add three icon with three horizontal dots * Change context menu icon for three horizontal dots	7 years ago
Oliver Günther	d3904ab8d2	[24842] Show attribute group for different project contexts (#5839) ... * Add currentProject service to detect the project context * Handle project context in single view * Fix global work package menu * Fix link to project id in single view [ci skip]	7 years ago
Oliver Günther	65b7de7bba	Better export_spec safeguard ... [ci skip]	7 years ago
Oliver Günther	4466832f38	[26044] Fix cancel editing for milestones (#5833) ... https://community.openproject.com/wp/26044 [ci skip]	7 years ago
Oliver Günther	3a6f2e2278	[26044] Handle escape in field handler and reference form in table (#5828) ... * [26044] Handle escape in field handler and reference form in table Mousetrap was used to trigger escape on the field, but since we already have a keydown handler attached to it, we can re-use it for cancelling the field editing. While fixing this, I found out that the table edit context uses a new form for each field, which means the edit handler of the previous field is lost. A new reference context is held in the table to return existing forms, if any. In the single view, this is tied to the $scope of the edit field group, and thus ensure only one form exists. * Fix specs of long text fields now no longer escape-able. [ci skip]	7 years ago
Oliver Günther	413b70a5f6	[26034] Set default CF values when switching types (#5826) ... Fixes switching to a type with a required CF with a default value set. https://community.openproject.com/wp/26034 [ci skip]	7 years ago
Oliver Günther	8d6b51f6e1	Add spec for edge case that was missed	7 years ago
Oliver Günther	4a8a16f82c	Don't gulp errors in PromiseLike	7 years ago
ulferts	b3efc877cd	adapt help text modal style (#5788) ... In order to allow using the keyboard to trigger the close button, the ngDialog close functionality is disabled and a custom close button (the X) is added which is tabbable. The rest is as specified in https://community.openproject.com/projects/openproject/work_packages/25912 Remove close button Change label to "Edit" (EN), "Bearbeiten" (DE) Decrease space between button and bottom. Remove blue border/highlight-effect around text Restore help/info icon left to header text [ci skip]	7 years ago
ulferts	4d95cc815f	Feature/guarded relation columns (#5784) ... * refactor case statement * guard relation columns by enterprise token [ci skip]	7 years ago
ulferts	e60bd97f35	Fix/bump gems (#5770) ... * bump capybara * downgrade selenium-webdriver to get rid of a multitued of log messages Setting the logging preferences had no effect: https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities#loggingpreferences-json-object * bump sass * bump openproject-token * bump autoprefixer-rails * bump database_cleaner * bump capybara-screenshot * bump aws-sdk * bump timecop * bump timecop * bump parallel_tests * bump faker * bump retriable * fix specs discovered to be broken by now working within Capybara introduced a proxy for `all` and `within` in v2.14 (6356719043 (diff-3944edd1c2651f608ed8a8bec061a734)). This revaled a couple of tests not working as desired. * skip `npm install` for unit specs [ci skip]	7 years ago
Oliver Günther	825a76f0e6	Add separate names to bulk actions	7 years ago
Oliver Günther	d01595d578	Test more explicitly in query_history spec	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	db4410dd1f	Remove single-wp edit in context menu	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	56b67e9f9e	Consolidate existing WorkPackageField and TableWorkPackageField	7 years ago
Oliver Günther	4a686f16d9	[25490] Add publicity settings for query saving modal (#5737) ... When copying queries, the publicity for other members is copied, but not the query `star` setting (whether it is shown in the project menu or not). This is confusing to the user in two ways: 1. The user does not know whether a query is public or not when copying it 2. It is weird to copy one setting, but not the other This PR suggests to extend the `save as` modal with the visibility settings. To this end, I extracted the visibility form into a separate directive to be re-used from the publish/sharing modal and the save as modal. As://community.openproject.com/projects/openproject/work_packages/25490 [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748) ... [ci skip]	7 years ago
Oliver Günther	ec6b856686	Add directive to show help text modal	7 years ago
Oliver Günther	9e576c9832	Alter specs after removed panel-toggler	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
Oliver Günther	04d48ecec9	Wait longer for filter values to be loaded	7 years ago
Oliver Günther	aaf9781698	Try to strengthen filter spec	7 years ago
Oliver Günther	eabadccab1	[25704] Allow activities to be filtered for comments-only ... This adds a simply toggler to the activity tab that allows filtering all activities for only those with a comment set. This was on the wish list for a customer but is so trivial that I did this in a quiet minute since I very much appreciate the idea. https://community.openproject.com/work_packages/25704 [ci skip]	7 years ago
ulferts	d1ddd2d5d2	Feature/toggle between hierarchy and group by (#5720) ... * allow toggling between hierarchy and groupBy * fix icon alignment in query settings dropdown * buffer query updates to prevent duplicate backend requests * simplify focus-within delay [ci skip]	7 years ago
Oliver Günther	8113ed9d19	Show relation rows as regular members of the table ... Still WIP: - Relation column is rendered as all other rows (indicator for dropdown), which is confusing	7 years ago
Oliver Günther	60de10881d	Strengthen relations spec	7 years ago