162 Commits (f8cdfde0f44c8f74470573a4cdd8b6dbd9971dda)

Author	SHA1	Message	Date
Benjamin Bädorf	beb4e6ba50	Refactor/user avatar to principal (#9069) ... * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Update user-avatar usages to principal * Fix some op-principal usages * Fix principal typing * Remove ls of non-existent directory * Rename more user-avatar instances * Avatars now render correctly * Fix an op-principal instance, default to avatar class for avatars * Always add principal id to default principal tag * Small fixes to op-principal * Fix multiline user display * Dirty fix for capybara click events * Update avatar sizing * Fixed some specs * Fix unit specs * Added op-link styles * Fix add placeholder image link * Remove byebug debugger statements Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	3b78be087b	Migrate tslint to eslint (#9064) ... * tslint to eslint migration * Autofix issues * Fix codeclimate path to eslintrc * Extend linter config for use with ng lint * Change prefix to op in angular lints	4 years ago
ulferts	64cf18856b	Revert "update locales from crowdin [ci skip]" ... This reverts commit 3cb8fef5e6.	4 years ago
Travis CI User	3cb8fef5e6	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012) ... * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
Travis CI User	3e239df370	update locales from crowdin [ci skip]	4 years ago
Travis CI User	f028241b61	update locales from crowdin [ci skip]	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944) ... * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973) ... * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943)	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937) ... * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
luz paz	e8c2928a12	Fix typo beeing->being in spec/ and modules/	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Travis CI User	1b5f100fe1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	bb62398263	update locales from crowdin [ci skip]	4 years ago
Travis CI User	a013096cd0	update locales from crowdin [ci skip]	4 years ago
Travis CI User	53cf33603c	update locales from crowdin [ci skip]	4 years ago
ulferts	cd24916f99	Fix/bump gems (#8865) ... * bump activerecord-nulldb-adapter and zeitwerk * bump aws-sdk-s3 * bump capybara * bump dry-core * bump faker * bump fog-aws * bump listen * bump loofah * bump net-ldap * bump parallel_tests * bump puma * bump omniauth-openid-connect * bump omniauth-openid_connect-providers * whitespace fixes * bump rubocop * bump newrelic_rpm * bump nokogumbo * bump fastimage	4 years ago
Travis CI User	ab08c9dfbf	update locales from crowdin [ci skip]	4 years ago
Travis CI User	175fed85d9	update locales from crowdin [ci skip]	4 years ago
ulferts	4dd8e433b4	Fix/bump gems (#8770) ... * bump aws-sdk-core * bump danger * bump parser * bump grape - stream related header setting bug has been fixed * reapply cache headers on stream as grape insists on niling them * bump aws-partitions * bump regexp_parser * bump rubocop * bump webmock	4 years ago
Travis CI User	35a35fb0b1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	66e2edb359	update locales from crowdin [ci skip]	4 years ago
Travis CI User	398ea7a764	update locales from crowdin [ci skip]	4 years ago
Travis CI User	12105b52de	update locales from crowdin [ci skip]	4 years ago
Travis CI User	12373985c7	update locales from crowdin [ci skip]	4 years ago
Travis CI User	257a3446bc	update locales from crowdin [ci skip]	4 years ago
Travis CI User	0fc7366013	update locales from crowdin [ci skip]	4 years ago
Travis CI User	4e8d752dee	update locales from crowdin [ci skip]	4 years ago
Travis CI User	ad8f9f6ad5	update locales from crowdin [ci skip]	4 years ago
Travis CI User	49d49ad8ef	update locales from crowdin [ci skip]	4 years ago
Travis CI User	a14f0e5f48	update locales from crowdin [ci skip]	4 years ago
Travis CI User	855c43eeac	update locales from crowdin [ci skip]	4 years ago
ulferts	27b41a313c	replace custom i18n function in views	4 years ago
Travis CI User	4ee33c3ac4	update locales from crowdin [ci skip]	4 years ago
Travis CI User	ff0b439c2b	update locales from crowdin [ci skip]	4 years ago
ulferts	f652819e71	replace deprecated URI.encode in gravatar_image_tag	4 years ago
Travis CI User	2da5e19159	update locales from crowdin [ci skip]	4 years ago
Travis CI User	25469a0698	update locales from crowdin [ci skip]	4 years ago
Travis CI User	2cc16f366b	update locales from crowdin [ci skip]	4 years ago
Travis CI User	28256c53d8	update locales from crowdin [ci skip]	4 years ago
Travis CI User	c1bda74a27	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b2f828d949	update locales from crowdin [ci skip]	4 years ago
Travis CI User	6fd3454b56	update locales from crowdin [ci skip]	4 years ago
Travis CI User	afcf2d2afb	update locales from crowdin [ci skip]	4 years ago
Travis CI User	99ab5beb11	update locales from crowdin [ci skip]	4 years ago
Travis CI User	0261c8ac6e	update locales from crowdin [ci skip]	4 years ago
Travis CI User	7cc8042865	update locales from crowdin [ci skip]	4 years ago
Travis CI User	ce4e77e946	update locales from crowdin [ci skip]	4 years ago