openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	d8cdfa8196	[34535] Override project limiting filter if subproject filter present When the query has an explicit SubProject or OnlySubproject filter, the project limiting filter based on the global settting does not really make any sense. It will prevent seeing any results when trying to view work packages from a subproject unless it is enabled globally. This change suggests to skip this limiting filter whenever an explicit subproject filter is added to the query. This fixes subproject boards when the global setting is enabled, since that sets only the `onlySubprojectFilter`. https://community.openproject.com/wp/34535	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Oliver Günther	e1a88a9a40	[34001] Ensure filters always receive the query context In the mentioned project, the query copy service fails to execute because a filter has lost its context right after `query.save`. There is a hook for `after_commit` which is not relevant here since we're in a transaction, but the context is lost regardless. Instead, we could ensure whenever accessing the filters, the context is set correctly. https://community.openproject.com/wp/34001	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	f4f1e98b20	[32156] Use backlogs sorting of versions date for work packages - Adds a null_handling option to the property columns to allow `NULLS FIRST/LAST` to be handled - Adds a query specific SortCriteria that can work with null_handling - Fixes sorting of allowed_versions to reuse that sort order https://community.openproject.com/wp/32156	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	c4dc6e2c91	ensure sums are also sorted by group_by column	5 years ago
ulferts	d9479cce81	exclude hidden queries from copying Copying those needs to be handled when implementing copying of boards and dashboards	5 years ago
Oliver Günther	bb6c428926	Silently remove parent sort_by	6 years ago
Oliver Günther	622e73664d	Remove hierarchy paths and migrate away from parent column	6 years ago
Oliver Günther	8ab4f2a663	Boards module (#7008 ) * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Push boards on grid * Use base class in scope [ci skip] * Extend api for options * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Save queries in grids [ci skip] * Renaming queries [ci skip] * Add existing work packages to board [ci skip] * Introduce card view component for work packages * Extend grids to allow project scope for boards (#7025) Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards). For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented. * introduce project association for boards * have dedicated grid registration classes * update and create form for board grids * extract defaults into grid registration [ci skip] * Add drag and drop to card view [ci skip] * Add options to grid * Fix option migration name * Renaming boards [ci skip] * Frontend deletion of boards * Avoid map on NodeList which doesnt exist [ci skip] * Add inline create to boards [ci skip] * Smaller create button [ci skip] * Add navigation for boards * Make inner grid same height * Replace index page with table * Workaround for widget registration [ci skip] * Fixed height for cards and tables [ci skip] * Implement escape as cancel d&d action [ci skip] * Fix and extend grid specs for name and options * Extend board specs for required name * Fix migration for MySQL references https://stackoverflow.com/a/45825566/420614 * Make board list extend from widget Since we cannot configure widgets yet, it's not yet possible to use a board-list widget anywhere. * Fix specs * Fix escape listener removal [ci skip] * Fix renamed to_path in relation spec [ci skip] * Allow deletion of grids for boards * Avoid reloading resource multiple times with replays * Frontend synchronization on deletion [ci skip] * Delete through table * Use work packages board path * Use work packages board path * Fix augmented columns breaking re-rendering * Fix duplicated permission with forums * Strengthen tab switch in specs * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * private queries * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * Move boards below work packages * Add Board configuration modal * Fix reloading with onPush * Saving / Switching of display mode [ci skip] * Extract wp-query-selectable-title into common component * Fix renaming of board-list * Fix auto-hide notifications in boards * Add permissions to seeders * Reorder lists in board * Linting * Remove default gravatar from settings * Show assignees avatar in the card view of WPs * Fix specs * Add missing method * Fix timeline icon * Use URL as input to be able to show avatars for groups, too * Fix test * Add further specs * Use correct data attribute to avoid unnecessary data base calls * Add further specs * Deletion of board lists * Pass permission via gon to decide whether we can create boards * Fix rename spec * Cherry-pick of `7873d59` and `30abc7f`	6 years ago
Oliver Günther	e9cc09840d	Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context.	6 years ago
Oliver Günther	f3e2100247	Save highlighting mode to query	6 years ago
Oliver Günther	1701750dda	Implement tab portal outlet with multiple attached views	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
ulferts	8c732b9a42	Fix/parent depth first sorting (#6133 ) * maintain hierarchy path for performant sorting * by default - only sort by parent Parent sorting is exclusive as the sorting used is depth first. Because of that, the id of the work package is always part of the parent order criteria. By that, all other properties of the work package become irrelevant. [ci skip]	7 years ago
Oliver Günther	941ed90b6a	Extract Custom Field mixin and subfilters Allows re-use of custom field filters in different contexts, with additional logic per custom field type (e.g., user with me values)	7 years ago
Oliver Günther	0d55bc0308	[26675] Remove implicit ID sorting on parent sort (#6039 ) * [26675] Remove implicit ID sorting on parent sort https://community.openproject.com/wp/26675 * parent sort -> breadth first sort, top down [ci skip]	7 years ago
Oliver Günther	648c1c363f	[26557] Output query name when using in string context [ci skip]	7 years ago
Oliver Günther	e1db97530d	[26330] Don't add project to query columns if already contained (#5929 ) [ci skip]	7 years ago
ulferts	c70aa76ea0	mimic AR join alias calculation for query (#5682 ) * mimic AR join alias calculation for query * remove unused columns parameter on v3 query get [ci skip]	7 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637 ) * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606 ) * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
Oliver Günther	5b5326db4c	[25438] Fix only saving changed column positions (#5608 ) When changing only the positions of the default query columns, the query incorrectly checked only for the permutation of the default columns, not the actual order. Thus the columns were not actually saved in the query. Additionally, the `observeUntilChanged` incorrectly reflects previous values which causes the movement of a column twice to only result in a move by one position. As this was already suggested to remove in https://github.com/opf/openproject/pull/5597, let's resolve this together in this PR. [ci skip]	8 years ago
ulferts	b396a4d97b	fix sorting by parent (#5580 ) The default direction is still ASC. But when applying the ASC statement directly to the sortable string, it becomes impossible to filter DESC. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579 ) * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574 ) * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
Oliver Günther	1259904d82	Fix ArgumentError in QueryRepresenter (#5564 ) quick fixes ``` ArgumentError: Column needs to be set from /usr/src/app/lib/api/v3/queries/sort_bys/sort_by_decorator.rb:41:in `initialize' from /usr/src/app/lib/api/v3/queries/query_serialization.rb:194:in `new' from /usr/src/app/lib/api/v3/queries/query_serialization.rb:194:in `block in map_with_sort_by_as_decorated' from /usr/src/app/lib/api/v3/queries/query_serialization.rb:193:in `map' ``` [ci skip]	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547 ) * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago
Jens Ulferts	874b2b1e65	rewrite setting columns to prevent setting to ''	8 years ago
Jens Ulferts	0a882deaf3	remove unused method	8 years ago
Jens Ulferts	4df369884a	employ the subproject filter to handle subproject setting	8 years ago
Jens Ulferts	1fe880ad1b	prevent query filters loosing their context	8 years ago
Jens Ulferts	3c6a93283b	simple code prettifications	8 years ago
Jens Ulferts	33545b9e39	refactor query filter statements into distinct classes	8 years ago
Oliver Günther	e2361e7994	Disallow hierarchy mode when group-by is active	8 years ago
Oliver Günther	7144f28662	[24972] Make hierarchy mode state part of query	8 years ago
Jens Ulferts	7918aa496c	avoid n+1 queries by using already loaded columns	8 years ago
cklein	8077afd57c	Filter by datetime and datetime range. https://community.openproject.com/work_packages/24174 See also previous PRs under #5071, #5128	8 years ago
Oliver Günther	3a539b6bdc	Fix specs	8 years ago
Oliver Günther	93dcd386f4	Remove usage of CF translations	8 years ago
Oliver Günther	b93b088940	Remove globalize, name_locales for custom fields	8 years ago
Jens Ulferts	40794f6901	clear memoized column information on context change	8 years ago
Markus Kahl	1b03231583	group_by may be blank	8 years ago

1 2 3 4 5 ...

330 Commits (f96894ed51ce9f3e52516e27296b958276373325)