30 Commits (fceedc7c88611f6bce9f4f35123814a1fc426a03)

Author	SHA1	Message	Date
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	2 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Christophe Bliard	47a297daae	Fix argument alignment since f08bea3467 (#10129) ... * Fix argument alignment since f08bea3467 The FactoryBot.* prefix has been removed in f08bea3467. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it. * do not fix alignments for modules/*/spec yet hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago
ulferts	0fe90c21a7	rework hidden/starred of queries ... The MenuItems::QueryMenuItems class used to map the `starred` state is replaced by a simple boolean flag. The hidden flag is removed (but still readable) as the concept of `View`s completely replaces it.	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	bc06da3a00	[30231] Allow users edit_work_packages permission to save query ... https://community.openproject.com/wp/30231	6 years ago
Jens Ulferts	395c665627	do not allow edit when user only has comment permission	6 years ago
Jens Ulferts	24bcf147f2	lift project restriction from children table	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	688385428c	Avoid multiple requires of spec_helper ... https://github.com/rspec/rspec-core/issues/1076	8 years ago
Jens Ulferts	34b26a4ff4	add service specific for adding notes to a work package	9 years ago
Oliver Günther	a6b4372b09	Always preprocess URLs with CGI.unescape ... This forces redirect URLs to always pass through the escaping process, in order to process escaped paths (`/mysubdir/%2E%2E/secret/`).	9 years ago
Oliver Günther	fcd450af3f	Fix redirect vulnerability ... `redirect_back_or_default` was vulnerable to some of the URLs found to be vulnerable in redmine, such as `@test.foo`. This commit extracts the whole functionality into a policy and alters the constraints with a path check to avoid these cases. Thanks to @marutosi for pointing this out. http://www.redmine.org/projects/redmine/repository/revisions/14560	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol ... The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	478b2c8859	Test manage subtasks policy	10 years ago
Philipp Tessenow	d7d1158d15	add specs for QueryPolicy:show	10 years ago
Hagen Schink	5d08947580	Test correct query deletion verb	10 years ago
Jens Ulferts	f7d92b156e	fixes permission links on query	10 years ago
Jens Ulferts	4817547d4a	introduces policies ... The pattern used here is taken from pundit although this here does by far not have the functionality pundit offers.	10 years ago