Merge pull request #1530 from bart1e/no_uppercase_for_public_vars

'Not in UPPER_CASE_WITH_UNDERSCORES' warning for public constant vars removed

slither/detectors/naming_convention/naming_convention.py

@@ -139,7 +139,8 @@ Solidity defines a [naming convention](https://solidity.readthedocs.io/en/v0.4.2
                     # For ERC20 compatibility
                     if var.name in ["symbol", "name", "decimals"]:
                         continue
-
+                    if var.visibility == "public":
+                        continue
                     if not self.is_upper_case_with_underscores(var.name):
                         info = [
                             "Constant ",

tests/detectors/naming-convention/0.4.25/no_warning_for_public_constants.sol

@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}

tests/detectors/naming-convention/0.4.25/no_warning_for_public_constants.sol.0.4.25.NamingConvention.json

@@ -0,0 +1,3 @@
+[
+    []
+]

tests/detectors/naming-convention/0.5.16/no_warning_for_public_constants.sol

@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}

tests/detectors/naming-convention/0.5.16/no_warning_for_public_constants.sol.0.5.16.NamingConvention.json

@@ -0,0 +1,3 @@
+[
+    []
+]

tests/detectors/naming-convention/0.6.11/no_warning_for_public_constants.sol

@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}

tests/detectors/naming-convention/0.6.11/no_warning_for_public_constants.sol.0.6.11.NamingConvention.json

@@ -0,0 +1,3 @@
+[
+    []
+]

tests/detectors/naming-convention/0.7.6/no_warning_for_public_constants.sol

@@ -0,0 +1,4 @@
+contract A 
+{ 
+    uint256 public constant myVal = 0; 
+}

tests/detectors/naming-convention/0.7.6/no_warning_for_public_constants.sol.0.7.6.NamingConvention.json

@@ -0,0 +1,3 @@
+[
+    []
+]

tests/test_detectors.py

@@ -609,6 +609,26 @@ ALL_TEST_OBJECTS = [
         "naming_convention.sol",
         "0.7.6",
     ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.4.25",
+    ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.5.16",
+    ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.6.11",
+    ),
+    Test(
+        all_detectors.NamingConvention,
+        "no_warning_for_public_constants.sol",
+        "0.7.6",
+    ),
     Test(
         all_detectors.ControlledDelegateCall,
         "controlled_delegatecall.sol",