Remove FP on locked_ether detector: follow through libraries calls to detect send of ethers (fix #163)

slither/detectors/attributes/locked_ether.py

@@ -5,7 +5,7 @@
 from slither.detectors.abstract_detector import (AbstractDetector,
                                                  DetectorClassification)
 from slither.slithir.operations import (HighLevelCall, LowLevelCall, Send,
-                                        Transfer, NewContract)
+                                        Transfer, NewContract, LibraryCall, InternalCall)
 
 
 class LockedEther(AbstractDetector):
@@ -37,6 +37,12 @@ Every ethers send to `Locked` will be lost.'''
     @staticmethod
     def do_no_send_ether(contract):
         functions = contract.all_functions_called
+        to_explore = functions
+        explored = []
+        while to_explore:
+            functions = to_explore
+            explored += to_explore
+            to_explore = []
             for function in functions:
                 calls = [c.name for c in function.internal_calls]
                 if 'suicide(address)' in calls or 'selfdestruct(address)' in calls:
@@ -49,6 +55,13 @@ Every ethers send to `Locked` will be lost.'''
                         if isinstance(ir, (LowLevelCall)):
                             if ir.function_name in ['delegatecall', 'callcode']:
                                 return False
+                        # If a new internal call or librarycall
+                        # Add it to the list to explore
+                        # InternalCall if to follow internal call in libraries
+                        if isinstance(ir, (InternalCall, LibraryCall)):
+                            if not ir.function in explored:
+                                to_explore.append(ir.function)
+
         return True