TheDude
/
slither
mirror of https://github.com/crytic/slither
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improved tests

Browse Source
pull/1022/head
Tadashi 3 years ago
parent b6103dd015
commit 6a4b97b7a7
6 changed files with 25 additions and 204 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 9
      tests/detectors/external-function/0.4.25/external_function_3.sol
  2. 129
      tests/detectors/external-function/0.4.25/external_function_3.sol.0.4.25.ExternalFunction.json
  3. 7
      tests/detectors/external-function/0.5.16/external_function_3.sol
  4. 62
      tests/detectors/external-function/0.5.16/external_function_3.sol.0.5.16.ExternalFunction.json
  5. 7
      tests/detectors/external-function/0.6.11/external_function_3.sol
  6. 7
      tests/detectors/external-function/0.7.6/external_function_3.sol

9
tests/detectors/external-function/0.4.25/external_function_3.sol
Unescape View File

@ -1,11 +1,10 @@
contract Test {
function test(bytes x) public {
function good(bytes x) external {}
function good2() public {}
}
function good3(uint256 x, uint256 y) public {}
function test2(bytes memory x) public {
}
function good4(uint256[] x, string y) external {}
}

129
tests/detectors/external-function/0.4.25/external_function_3.sol.0.4.25.ExternalFunction.json
Unescape View File

@ -1,130 +1,3 @@
[
[
{
"elements": [
{
"type": "function",
"name": "test",
"source_mapping": {
"start": 21,
"length": 46,
"filename_used": "/GENERIC_PATH",
"filename_relative": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"is_dependency": false,
"lines": [
3,
4,
5
],
"starting_column": 5,
"ending_column": 6
},
"type_specific_fields": {
"parent": {
"type": "contract",
"name": "Test",
"source_mapping": {
"start": 0,
"length": 134,
"filename_used": "/GENERIC_PATH",
"filename_relative": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"is_dependency": false,
"lines": [
1,
2,
3,
4,
5,
6,
7,
8,
9,
10,
11,
12
],
"starting_column": 1,
"ending_column": 0
}
},
"signature": "test(bytes)"
}
}
],
"description": "test(bytes) should be declared external:\n\t- Test.test(bytes) (tests/detectors/external-function/0.4.25/external_function_3.sol#3-5)\n",
"markdown": "test(bytes) should be declared external:\n\t- [Test.test(bytes)](tests/detectors/external-function/0.4.25/external_function_3.sol#L3-L5)\n",
"first_markdown_element": "tests/detectors/external-function/0.4.25/external_function_3.sol#L3-L5",
"id": "058fd57c313c645eff4b4e53234ca0f73ca3362bd28d3fdc90e0219a32099592",
"check": "external-function",
"impact": "Optimization",
"confidence": "High"
},
{
"elements": [
{
"type": "function",
"name": "test2",
"source_mapping": {
"start": 73,
"length": 54,
"filename_used": "/GENERIC_PATH",
"filename_relative": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"is_dependency": false,
"lines": [
7,
8,
9
],
"starting_column": 5,
"ending_column": 6
},
"type_specific_fields": {
"parent": {
"type": "contract",
"name": "Test",
"source_mapping": {
"start": 0,
"length": 134,
"filename_used": "/GENERIC_PATH",
"filename_relative": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/external-function/0.4.25/external_function_3.sol",
"is_dependency": false,
"lines": [
1,
2,
3,
4,
5,
6,
7,
8,
9,
10,
11,
12
],
"starting_column": 1,
"ending_column": 0
}
},
"signature": "test2(bytes)"
}
}
],
"description": "test2(bytes) should be declared external:\n\t- Test.test2(bytes) (tests/detectors/external-function/0.4.25/external_function_3.sol#7-9)\n",
"markdown": "test2(bytes) should be declared external:\n\t- [Test.test2(bytes)](tests/detectors/external-function/0.4.25/external_function_3.sol#L7-L9)\n",
"first_markdown_element": "tests/detectors/external-function/0.4.25/external_function_3.sol#L7-L9",
"id": "a5b4753f43bb5a2a669ecbf4ce6ab1aaff060454657b16b5ed8cc9c34b521c79",
"check": "external-function",
"impact": "Optimization",
"confidence": "High"
}
]
[]
]

7
tests/detectors/external-function/0.5.16/external_function_3.sol
Unescape View File

@ -1,7 +1,10 @@
contract Test {
function test(bytes memory x) public {
function good(bytes calldata x) external {}
function good2() public {}
}
function good3(uint256 x, uint256 y) public {}
function good4(uint256[] calldata x, string calldata y) external {}
}

62
tests/detectors/external-function/0.5.16/external_function_3.sol.0.5.16.ExternalFunction.json
Unescape View File

@ -1,63 +1,3 @@
[
[
{
"elements": [
{
"type": "function",
"name": "test",
"source_mapping": {
"start": 21,
"length": 53,
"filename_used": "/GENERIC_PATH",
"filename_relative": "tests/detectors/external-function/0.5.16/external_function_3.sol",
"filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/external-function/0.5.16/external_function_3.sol",
"is_dependency": false,
"lines": [
3,
4,
5
],
"starting_column": 5,
"ending_column": 6
},
"type_specific_fields": {
"parent": {
"type": "contract",
"name": "Test",
"source_mapping": {
"start": 0,
"length": 77,
"filename_used": "/GENERIC_PATH",
"filename_relative": "tests/detectors/external-function/0.5.16/external_function_3.sol",
"filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/external-function/0.5.16/external_function_3.sol",
"is_dependency": false,
"lines": [
1,
2,
3,
4,
5,
6,
7,
8
],
"starting_column": 1,
"ending_column": 0
}
},
"signature": "test(bytes)"
}
}
],
"description": "test(bytes) should be declared external:\n\t- Test.test(bytes) (tests/detectors/external-function/0.5.16/external_function_3.sol#3-5)\n",
"markdown": "test(bytes) should be declared external:\n\t- [Test.test(bytes)](tests/detectors/external-function/0.5.16/external_function_3.sol#L3-L5)\n",
"first_markdown_element": "tests/detectors/external-function/0.5.16/external_function_3.sol#L3-L5",
"id": "058fd57c313c645eff4b4e53234ca0f73ca3362bd28d3fdc90e0219a32099592",
"check": "external-function",
"impact": "Optimization",
"confidence": "High"
}
]
[]
]

7
tests/detectors/external-function/0.6.11/external_function_3.sol
Unescape View File

@ -1,7 +1,10 @@
contract Test {
function test(bytes memory x) public {
function good(bytes calldata x) external {}
function good2() public {}
}
function good3(uint256 x, uint256 y) public {}
function good4(uint256[] calldata x, string calldata y) external {}
}

7
tests/detectors/external-function/0.7.6/external_function_3.sol
Unescape View File

@ -1,7 +1,10 @@
contract Test {
function test(bytes memory x) public {
function good(bytes calldata x) external {}
function good2() public {}
}
function good3(uint256 x, uint256 y) public {}
function good4(uint256[] calldata x, string calldata y) external {}
}
Write Preview
Loading…
Cancel
Save