change confidence to high

slither/detectors/variables/var_read_using_this.py

@@ -9,7 +9,7 @@ class VarReadUsingThis(AbstractDetector):
     ARGUMENT = "var-read-using-this"
     HELP = "Contract reads its own variable using `this`"
     IMPACT = DetectorClassification.OPTIMIZATION
-    CONFIDENCE = DetectorClassification.MEDIUM
+    CONFIDENCE = DetectorClassification.HIGH
 
     WIKI = "https://github.com/trailofbits/slither-private/wiki/Vulnerabilities-Description#var-read-using-this"
 

tests/detectors/var-read-using-this/0.5.16/var_read_using_this.sol.0.5.16.VarReadUsingThis.json

@@ -168,7 +168,7 @@
             "id": "0178009997f4d2c4d9a3a9e966bc7c3277ba1ce8c8c412b04fbe2cab3eab1b64",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -338,7 +338,7 @@
             "id": "1aeda0f171a714323d2cc886a4569374dcecf4a31bfd07dd341985cb91c1cda4",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -512,7 +512,7 @@
             "id": "512bc7a6d6d4fc95951dd03634d193a2e29b0162882a8b4be6e27ff899e21b2d",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -682,7 +682,7 @@
             "id": "e230fb1483c53ad953389bae20f599c95bbb5feb0040a4b9c33da5ec96682eff",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         }
     ]
 ]

tests/detectors/var-read-using-this/0.6.11/var_read_using_this.sol.0.6.11.VarReadUsingThis.json

@@ -168,7 +168,7 @@
             "id": "0207d6c951b693638b81afe89cdee392fd61a671e0a92e1f8c8b4e5824b1d25b",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -338,7 +338,7 @@
             "id": "58da220580586bad1af775ff0da07248cea80f98a30f3173c494ce5517d4b041",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -512,7 +512,7 @@
             "id": "6d5eeb058ec44a05d486b3ee7c2911a7f5306b3d0b619a52ae08efe195c8614c",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -682,7 +682,7 @@
             "id": "b8b557dc26e17f526df0fd98af8c5d06013dd18b163e05a281ea1519e15ca24e",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         }
     ]
 ]

tests/detectors/var-read-using-this/0.7.6/var_read_using_this.sol.0.7.6.VarReadUsingThis.json

@@ -168,7 +168,7 @@
             "id": "44eec3d0ad87871981571b3d571f13579272bdabcfebe6bd25ac2880d2bf3c33",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -342,7 +342,7 @@
             "id": "519caa8ce5e7990c223fd65d827817bb93fe3020efcf9133f204f7a80f6a4e7f",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -512,7 +512,7 @@
             "id": "7f28036af3c8cd6bc29a5a25378629d8f703b655a55f3a5cf36e8b96a11c792a",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -682,7 +682,7 @@
             "id": "a19dc63eefbe43a4a7642c957b7b96fad0c42563e18d0b03fb1592c1ad5bad04",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         }
     ]
 ]

tests/detectors/var-read-using-this/0.8.15/var_read_using_this.sol.0.8.15.VarReadUsingThis.json

@@ -172,7 +172,7 @@
             "id": "1224862cf823193c24ce4a02579e7b9cf0eaded7167e8c9f9ed2861d9a9910cc",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -342,7 +342,7 @@
             "id": "29d9293adc1046d877a098beb2f9b7757658226e50c6d28228df65dfeeba7fd8",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -512,7 +512,7 @@
             "id": "38e0c82eed10e2c79f5d232284f6e0d0b12966f71eaee7a5139a82e927d38005",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         },
         {
             "elements": [
@@ -682,7 +682,7 @@
             "id": "aa84305fa524be189a9e050c79cea81a7bc258614c7563e22738e17a3559615a",
             "check": "var-read-using-this",
             "impact": "Optimization",
-            "confidence": "Medium"
+            "confidence": "High"
         }
     ]
 ]