TheDude
/
slither
mirror of https://github.com/crytic/slither
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

exclude storage params

Browse Source
pull/1725/head
alpharush 2 years ago
parent 9acddc3259
commit e26a520766
3 changed files with 24 additions and 13 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 3
      slither/detectors/variables/uninitialized_storage_variables.py
  2. 7
      tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol
  3. 27
      tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol.0.8.19.UninitializedStorageVars.json

3
slither/detectors/variables/uninitialized_storage_variables.py
Unescape View File

@ -103,8 +103,9 @@ Bob calls `func`. As a result, `owner` is overridden to `0`.
for contract in self.compilation_unit.contracts: for contract in self.compilation_unit.contracts:
for function in contract.functions: for function in contract.functions:
if function.is_implemented and function.entry_point: if function.is_implemented and function.entry_point:
locals_except_params = set(function.variables) - set(function.parameters)
uninitialized_storage_variables = [ uninitialized_storage_variables = [
v for v in function.variables if v.is_storage and v.uninitialized v for v in locals_except_params if v.is_storage and v.uninitialized
] ]
function.entry_point.context[self.key] = uninitialized_storage_variables function.entry_point.context[self.key] = uninitialized_storage_variables

7
tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol
Unescape View File

@ -4,9 +4,14 @@ contract Uninitialized{
uint a; uint a;
} }
function test() internal returns (St storage ret){ function bad() internal returns (St storage ret){
ret = ret; ret = ret;
ret.a += 1; ret.a += 1;
} }
function ok(St storage ret) internal {
ret = ret;
ret.a += 1;
}
} }

27
tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol.0.8.19.UninitializedStorageVars.json
Unescape View File

@ -6,7 +6,7 @@
"type": "variable", "type": "variable",
"name": "ret", "name": "ret",
"source_mapping": { "source_mapping": {
"start": 101, "start": 100,
"length": 14, "length": 14,
"filename_relative": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol", "filename_relative": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol",
"filename_absolute": "/GENERIC_PATH", "filename_absolute": "/GENERIC_PATH",
@ -15,16 +15,16 @@
"lines": [ "lines": [
7 7
], ],
"starting_column": 39, "starting_column": 38,
"ending_column": 53 "ending_column": 52
}, },
"type_specific_fields": { "type_specific_fields": {
"parent": { "parent": {
"type": "function", "type": "function",
"name": "test", "name": "bad",
"source_mapping": { "source_mapping": {
"start": 67, "start": 67,
"length": 96, "length": 95,
"filename_relative": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol", "filename_relative": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol",
"filename_absolute": "/GENERIC_PATH", "filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol", "filename_short": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol",
@ -44,7 +44,7 @@
"name": "Uninitialized", "name": "Uninitialized",
"source_mapping": { "source_mapping": {
"start": 0, "start": 0,
"length": 170, "length": 262,
"filename_relative": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol", "filename_relative": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol",
"filename_absolute": "/GENERIC_PATH", "filename_absolute": "/GENERIC_PATH",
"filename_short": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol", "filename_short": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol",
@ -61,22 +61,27 @@
9, 9,
10, 10,
11, 11,
12 12,
13,
14,
15,
16,
17
], ],
"starting_column": 1, "starting_column": 1,
"ending_column": 2 "ending_column": 2
} }
}, },
"signature": "test()" "signature": "bad()"
} }
} }
} }
} }
], ],
"description": "Uninitialized.test().ret (tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol#7) is a storage variable never initialized\n", "description": "Uninitialized.bad().ret (tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol#7) is a storage variable never initialized\n",
"markdown": "[Uninitialized.test().ret](tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol#L7) is a storage variable never initialized\n", "markdown": "[Uninitialized.bad().ret](tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol#L7) is a storage variable never initialized\n",
"first_markdown_element": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol#L7", "first_markdown_element": "tests/detectors/uninitialized-storage/0.8.19/uninitialized_storage_pointer.sol#L7",
"id": "cc7efd7ba9d430d21b17f18d15e561d2e188b59a3d62b9c5e76eeec765626cbd", "id": "979d28e501693ed7ece0d429e7c30266f8e9d6a2e2eedc87006c4bad63e78706",
"check": "uninitialized-storage", "check": "uninitialized-storage",
"impact": "High", "impact": "High",
"confidence": "High" "confidence": "High"

Write Preview
Loading…
Cancel
Save