Merge pull request #143 from sc-forks/constant-is-view

Post-process exclude constant modifier too

lib/app.js

@@ -286,11 +286,13 @@ class App {
     shell.ls(`${env}/**/*.sol`).forEach(file => {
       const pureRe = /\spure\s/gi;
       const viewRe = /\sview\s/gi;
+      const constantRe = /\sconstant\s/gi;
 
       const contractPath = this.platformNeutralPath(file);
       let contract = fs.readFileSync(contractPath).toString();
       contract = contract.replace(pureRe, ' ');
       contract = contract.replace(viewRe, ' ');
+      contract = contract.replace(constantRe, ' ');
       fs.writeFileSync(contractPath, contract);
     })
   }

test/cli/totallyPure.js

@@ -15,11 +15,16 @@ contract('TotallyPure', accounts => {
     const value = await instance.isPure(4,5);
   });
 
-  it('calls an importend, inherited view function', async function(){
+  it('calls an imported, inherited view function', async function(){
     const instance = await TotallyPure.deployed();
     const value = await instance.isView();
   })
 
+  it('calls an imported, inherited constant function', async function(){
+    const instance = await TotallyPure.deployed();
+    const value = await instance.isConstant();
+  })
+
   it('overrides an imported, inherited abstract pure function', async function(){
     const instance = await TotallyPure.deployed();
     const value = await instance.bePure(4,5);
@@ -29,4 +34,9 @@ contract('TotallyPure', accounts => {
     const instance = await TotallyPure.deployed();
     const value = await instance.beView();
   });
+
+  it('overrides an imported, inherited abstract constant function', async function(){
+    const instance = await TotallyPure.deployed();
+    const value = await instance.beConstant();
+  });
 });

test/sources/cli/PureView.sol

@@ -8,4 +8,5 @@ contract PureView {
   // Abstract functions to inherit from an uninstrumented, imported file.
   function bePure(uint a, uint b) pure returns (uint);
   function beView() view returns (uint);
+  function beConstant() constant returns (uint);
 }

test/sources/cli/TotallyPure.sol

@@ -18,6 +18,14 @@ contract TotallyPure is PureView {
     return notpureview;
   }
 
+  function isConstant() constant returns (uint){
+    return onehundred;
+  }
+
+  function beConstant() constant returns (uint){
+    return onehundred;
+  }
+
   function bePure(uint a, uint b) pure returns (uint) {
     return a + b;
   }