Add tests for user profiles (#6568)

* test each profile
* removed duplicated line
* use non-deprecated name for sync mode

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

besu/src/test/java/org/hyperledger/besu/cli/CascadingDefaultProviderTest.java

@@ -182,8 +182,6 @@ public class CascadingDefaultProviderTest extends CommandTestAbstract {
     assertThat(syncConfig.getSyncMode()).isEqualTo(SyncMode.FAST);
     assertThat(syncConfig.getFastSyncMinimumPeerCount()).isEqualTo(5);
 
-    assertThat(commandErrorOutput.toString(UTF_8)).isEmpty();
-
     assertThat(commandOutput.toString(UTF_8)).isEmpty();
     assertThat(commandErrorOutput.toString(UTF_8)).isEmpty();
   }

besu/src/test/java/org/hyperledger/besu/cli/ProfilesTest.java

@@ -0,0 +1,37 @@
+/*
+ * Copyright Hyperledger Besu Contributors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations under the License.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+package org.hyperledger.besu.cli;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.hyperledger.besu.cli.config.ProfileName;
+
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+
+public class ProfilesTest extends CommandTestAbstract {
+
+  /** Test if besu will validate the combination of options within the given profile. */
+  @ParameterizedTest
+  @EnumSource(ProfileName.class)
+  public void testProfileWithNoOverrides_doesNotError(final ProfileName profileName) {
+
+    parseCommand("--profile", profileName.name());
+
+    assertThat(commandOutput.toString(UTF_8)).isEmpty();
+    assertThat(commandErrorOutput.toString(UTF_8)).isEmpty();
+  }
+}

config/src/main/resources/profiles/minimalist-staker.toml

@@ -1,4 +1,4 @@
-sync-mode="X_CHECKPOINT"
+sync-mode="CHECKPOINT"
 data-storage-format="BONSAI"
 bonsai-historical-block-limit=128
 max-peers=25