PR checklist - remove checkbox for non-mainnet ATs (#5514)

* removed non-mainnetATs line

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
pull/5522/head
Sally MacFarlane 2 years ago committed by GitHub
parent b612ee29d1
commit db410621b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      .github/workflows/pr-checklist-on-open.yml
  2. 4
      ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCall.java

@ -16,5 +16,5 @@ jobs:
issue_number: context.issue.number, issue_number: context.issue.number,
owner: context.repo.owner, owner: context.repo.owner,
repo: context.repo.repo, repo: context.repo.repo,
body: '- [ ] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation).\n- [ ] I have considered running `./gradlew acceptanceTestNonMainnet` locally if my PR affects non-mainnet modules.\n- [ ] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog).\n- [ ] If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests' body: '- [ ] I thought about documentation and added the `doc-change-required` label to this PR if [updates are required](https://wiki.hyperledger.org/display/BESU/Documentation).\n- [ ] I thought about the changelog and included a [changelog update if required](https://wiki.hyperledger.org/display/BESU/Changelog).\n- [ ] If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests'
}) })

@ -140,7 +140,7 @@ public class EthCall extends AbstractBlockParameterOrBlockHashMethod {
// be decided according to the provided parameters // be decided according to the provided parameters
if (callParams.isMaybeStrict().isEmpty()) { if (callParams.isMaybeStrict().isEmpty()) {
transactionValidationParams.isAllowExceedingBalance( transactionValidationParams.isAllowExceedingBalance(
isAllowExeedingBalanceAutoSelection(header, callParams)); isAllowExceedingBalanceAutoSelection(header, callParams));
} else { } else {
transactionValidationParams.isAllowExceedingBalance( transactionValidationParams.isAllowExceedingBalance(
!callParams.isMaybeStrict().orElse(Boolean.FALSE)); !callParams.isMaybeStrict().orElse(Boolean.FALSE));
@ -148,7 +148,7 @@ public class EthCall extends AbstractBlockParameterOrBlockHashMethod {
return transactionValidationParams.build(); return transactionValidationParams.build();
} }
private boolean isAllowExeedingBalanceAutoSelection( private boolean isAllowExceedingBalanceAutoSelection(
final BlockHeader header, final JsonCallParameter callParams) { final BlockHeader header, final JsonCallParameter callParams) {
boolean isZeroGasPrice = boolean isZeroGasPrice =

Loading…
Cancel
Save