|
|
|
// Copyright 2014 The go-ethereum Authors
|
|
|
|
// This file is part of the go-ethereum library.
|
|
|
|
//
|
|
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU Lesser General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
package core
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"fmt"
|
|
|
|
"math"
|
|
|
|
"math/big"
|
|
|
|
"sort"
|
|
|
|
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
|
|
"github.com/ethereum/go-ethereum/rlp"
|
|
|
|
"github.com/harmony-one/harmony/core/types"
|
|
|
|
"github.com/harmony-one/harmony/core/vm"
|
|
|
|
"github.com/harmony-one/harmony/internal/params"
|
|
|
|
"github.com/harmony-one/harmony/internal/utils"
|
|
|
|
staking2 "github.com/harmony-one/harmony/staking"
|
|
|
|
stakingReward "github.com/harmony-one/harmony/staking/reward"
|
|
|
|
staking "github.com/harmony-one/harmony/staking/types"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
|
|
|
errInvalidSigner = errors.New("invalid signer for staking transaction")
|
|
|
|
errInsufficientBalanceForGas = errors.New("insufficient balance to pay for gas")
|
|
|
|
errInsufficientBalanceForStake = errors.New("insufficient balance to stake")
|
|
|
|
errValidatorExist = errors.New("staking validator already exists")
|
|
|
|
errValidatorNotExist = errors.New("staking validator does not exist")
|
|
|
|
errNoDelegationToUndelegate = errors.New("no delegation to undelegate")
|
|
|
|
errCommissionRateChangeTooFast = errors.New("change on commission rate can not be more than max change rate within the same epoch")
|
|
|
|
errCommissionRateChangeTooHigh = errors.New("commission rate can not be higher than maximum commission rate")
|
|
|
|
errCommissionRateChangeTooLow = errors.New("commission rate can not be lower than min rate of 5%")
|
|
|
|
errNoRewardsToCollect = errors.New("no rewards to collect")
|
|
|
|
errNegativeAmount = errors.New("amount can not be negative")
|
|
|
|
errDupIdentity = errors.New("validator identity exists")
|
|
|
|
errDupBlsKey = errors.New("BLS key exists")
|
|
|
|
)
|
|
|
|
|
|
|
|
/*
|
|
|
|
StateTransition is the State Transitioning Model which is described as follows:
|
|
|
|
|
|
|
|
A state transition is a change made when a transaction is applied to the current world state
|
|
|
|
The state transitioning model does all the necessary work to work out a valid new state root.
|
|
|
|
|
|
|
|
1) Nonce handling
|
|
|
|
2) Pre pay gas
|
|
|
|
3) Create a new state object if the recipient is \0*32
|
|
|
|
4) Value transfer
|
|
|
|
== If contract creation ==
|
|
|
|
4a) Attempt to run transaction data
|
|
|
|
4b) If valid, use result as code for the new state object
|
|
|
|
== end ==
|
|
|
|
5) Run Script section
|
|
|
|
6) Derive new state root
|
|
|
|
*/
|
|
|
|
type StateTransition struct {
|
|
|
|
gp *GasPool
|
|
|
|
msg Message
|
|
|
|
gas uint64
|
|
|
|
gasPrice *big.Int
|
|
|
|
initialGas uint64
|
|
|
|
value *big.Int
|
|
|
|
data []byte
|
|
|
|
state vm.StateDB
|
|
|
|
evm *vm.EVM
|
|
|
|
bc ChainContext
|
|
|
|
}
|
|
|
|
|
|
|
|
// Message represents a message sent to a contract.
|
|
|
|
type Message interface {
|
|
|
|
From() common.Address
|
|
|
|
//FromFrontier() (common.Address, error)
|
|
|
|
To() *common.Address
|
|
|
|
|
|
|
|
GasPrice() *big.Int
|
|
|
|
Gas() uint64
|
|
|
|
Value() *big.Int
|
|
|
|
|
|
|
|
Nonce() uint64
|
|
|
|
CheckNonce() bool
|
|
|
|
Data() []byte
|
|
|
|
Type() types.TransactionType
|
|
|
|
BlockNum() *big.Int
|
|
|
|
}
|
|
|
|
|
|
|
|
// ExecutionResult is the return value from a transaction committed to the DB
|
|
|
|
type ExecutionResult struct {
|
|
|
|
ReturnData []byte
|
|
|
|
UsedGas uint64
|
|
|
|
VMErr error
|
|
|
|
}
|
|
|
|
|
|
|
|
// Unwrap returns the internal evm error which allows us for further
|
|
|
|
// analysis outside.
|
|
|
|
func (result *ExecutionResult) Unwrap() error {
|
|
|
|
return result.VMErr
|
|
|
|
}
|
|
|
|
|
|
|
|
// Failed returns the indicator whether the execution is successful or not
|
|
|
|
func (result *ExecutionResult) Failed() bool { return result.VMErr != nil }
|
|
|
|
|
|
|
|
// Return is a helper function to help caller distinguish between revert reason
|
|
|
|
// and function return. Return returns the data after execution if no error occurs.
|
|
|
|
func (result *ExecutionResult) Return() []byte {
|
|
|
|
if result.VMErr != nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return common.CopyBytes(result.ReturnData)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Revert returns the concrete revert reason if the execution is aborted by `REVERT`
|
|
|
|
// opcode. Note the reason can be nil if no data supplied with revert opcode.
|
|
|
|
func (result *ExecutionResult) Revert() []byte {
|
|
|
|
if result.VMErr != vm.ErrExecutionReverted {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return common.CopyBytes(result.ReturnData)
|
|
|
|
}
|
|
|
|
|
|
|
|
// IntrinsicGas computes the 'intrinsic gas' for a message with the given data.
|
|
|
|
func IntrinsicGas(data []byte, contractCreation, homestead, istanbul, isValidatorCreation bool) (uint64, error) {
|
|
|
|
// Set the starting gas for the raw transaction
|
|
|
|
var gas uint64
|
|
|
|
if contractCreation && homestead {
|
|
|
|
gas = params.TxGasContractCreation
|
|
|
|
} else if isValidatorCreation {
|
|
|
|
gas = params.TxGasValidatorCreation
|
|
|
|
} else {
|
|
|
|
gas = params.TxGas
|
|
|
|
}
|
|
|
|
// Bump the required gas by the amount of transactional data
|
|
|
|
if len(data) > 0 {
|
|
|
|
// Zero and non-zero bytes are priced differently
|
|
|
|
var nz uint64
|
|
|
|
for _, byt := range data {
|
|
|
|
if byt != 0 {
|
|
|
|
nz++
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Make sure we don't exceed uint64 for all data combinations
|
|
|
|
nonZeroGas := params.TxDataNonZeroGasFrontier
|
|
|
|
if istanbul {
|
|
|
|
nonZeroGas = params.TxDataNonZeroGasEIP2028
|
|
|
|
}
|
|
|
|
if (math.MaxUint64-gas)/nonZeroGas < nz {
|
|
|
|
return 0, vm.ErrOutOfGas
|
|
|
|
}
|
|
|
|
gas += nz * nonZeroGas
|
|
|
|
|
|
|
|
z := uint64(len(data)) - nz
|
|
|
|
if (math.MaxUint64-gas)/params.TxDataZeroGas < z {
|
|
|
|
return 0, vm.ErrOutOfGas
|
|
|
|
}
|
|
|
|
gas += z * params.TxDataZeroGas
|
|
|
|
}
|
|
|
|
return gas, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// NewStateTransition initialises and returns a new state transition object.
|
|
|
|
func NewStateTransition(evm *vm.EVM, msg Message, gp *GasPool, bc ChainContext) *StateTransition {
|
|
|
|
return &StateTransition{
|
|
|
|
gp: gp,
|
|
|
|
evm: evm,
|
|
|
|
msg: msg,
|
|
|
|
gasPrice: msg.GasPrice(),
|
|
|
|
value: msg.Value(),
|
|
|
|
data: msg.Data(),
|
|
|
|
state: evm.StateDB,
|
|
|
|
bc: bc,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// ApplyMessage computes the new state by applying the given message
|
|
|
|
// against the old state within the environment.
|
|
|
|
//
|
|
|
|
// ApplyMessage returns the bytes returned by any EVM execution (if it took place),
|
|
|
|
// the gas used (which includes gas refunds) and an error if it failed. An error always
|
|
|
|
// indicates a core error meaning that the message would always fail for that particular
|
|
|
|
// state and would never be accepted within a block.
|
|
|
|
func ApplyMessage(evm *vm.EVM, msg Message, gp *GasPool) (ExecutionResult, error) {
|
|
|
|
return NewStateTransition(evm, msg, gp, nil).TransitionDb()
|
|
|
|
}
|
|
|
|
|
|
|
|
// ApplyStakingMessage computes the new state for staking message
|
|
|
|
func ApplyStakingMessage(evm *vm.EVM, msg Message, gp *GasPool, bc ChainContext) (uint64, error) {
|
|
|
|
return NewStateTransition(evm, msg, gp, bc).StakingTransitionDb()
|
|
|
|
}
|
|
|
|
|
|
|
|
// to returns the recipient of the message.
|
|
|
|
func (st *StateTransition) to() common.Address {
|
|
|
|
if st.msg == nil || st.msg.To() == nil /* contract creation */ {
|
|
|
|
return common.Address{}
|
|
|
|
}
|
|
|
|
return *st.msg.To()
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) useGas(amount uint64) error {
|
|
|
|
if st.gas < amount {
|
|
|
|
return vm.ErrOutOfGas
|
|
|
|
}
|
|
|
|
st.gas -= amount
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) buyGas() error {
|
|
|
|
mgval := new(big.Int).Mul(new(big.Int).SetUint64(st.msg.Gas()), st.gasPrice)
|
|
|
|
if have := st.state.GetBalance(st.msg.From()); have.Cmp(mgval) < 0 {
|
|
|
|
return errors.Wrapf(
|
|
|
|
errInsufficientBalanceForGas,
|
|
|
|
"had: %s but need: %s", have.String(), mgval.String(),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
if err := st.gp.SubGas(st.msg.Gas()); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
st.gas += st.msg.Gas()
|
|
|
|
|
|
|
|
st.initialGas = st.msg.Gas()
|
|
|
|
st.state.SubBalance(st.msg.From(), mgval)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) preCheck() error {
|
|
|
|
// Make sure this transaction's nonce is correct.
|
|
|
|
if st.msg.CheckNonce() {
|
|
|
|
nonce := st.state.GetNonce(st.msg.From())
|
|
|
|
|
|
|
|
if nonce < st.msg.Nonce() {
|
|
|
|
return ErrNonceTooHigh
|
|
|
|
} else if nonce > st.msg.Nonce() {
|
|
|
|
return ErrNonceTooLow
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return st.buyGas()
|
|
|
|
}
|
|
|
|
|
|
|
|
// TransitionDb will transition the state by applying the current message and
|
|
|
|
// returning the result including the used gas. It returns an error if failed.
|
|
|
|
// An error indicates a consensus issue.
|
|
|
|
func (st *StateTransition) TransitionDb() (ExecutionResult, error) {
|
|
|
|
if err := st.preCheck(); err != nil {
|
|
|
|
return ExecutionResult{}, err
|
|
|
|
}
|
|
|
|
msg := st.msg
|
|
|
|
sender := vm.AccountRef(msg.From())
|
|
|
|
homestead := st.evm.ChainConfig().IsS3(st.evm.EpochNumber) // s3 includes homestead
|
|
|
|
istanbul := st.evm.ChainConfig().IsIstanbul(st.evm.EpochNumber)
|
|
|
|
contractCreation := msg.To() == nil
|
|
|
|
|
|
|
|
// Pay intrinsic gas
|
|
|
|
gas, err := IntrinsicGas(st.data, contractCreation, homestead, istanbul, false)
|
|
|
|
if err != nil {
|
|
|
|
return ExecutionResult{}, err
|
|
|
|
}
|
|
|
|
if err = st.useGas(gas); err != nil {
|
|
|
|
return ExecutionResult{}, fmt.Errorf("%w: have %d, want %d", ErrIntrinsicGas, st.gas, gas)
|
|
|
|
}
|
|
|
|
|
|
|
|
evm := st.evm
|
|
|
|
|
|
|
|
var ret []byte
|
|
|
|
// All VM errors are valid except for insufficient balance, therefore returned separately
|
|
|
|
var vmErr error
|
|
|
|
|
|
|
|
if contractCreation {
|
|
|
|
ret, _, st.gas, vmErr = evm.Create(sender, st.data, st.gas, st.value)
|
|
|
|
} else {
|
|
|
|
// Increment the nonce for the next transaction
|
|
|
|
st.state.SetNonce(msg.From(), st.state.GetNonce(sender.Address())+1)
|
|
|
|
ret, st.gas, vmErr = evm.Call(sender, st.to(), st.data, st.gas, st.value)
|
|
|
|
}
|
|
|
|
if vmErr != nil {
|
|
|
|
utils.Logger().Debug().Err(vmErr).Msg("VM returned with error")
|
|
|
|
// The only possible consensus-error would be if there wasn't
|
|
|
|
// sufficient balance to make the transfer happen. The first
|
|
|
|
// balance transfer may never fail.
|
|
|
|
|
|
|
|
if vmErr == vm.ErrInsufficientBalance {
|
|
|
|
return ExecutionResult{}, vmErr
|
|
|
|
}
|
|
|
|
}
|
|
|
|
st.refundGas()
|
|
|
|
|
|
|
|
// Burn Txn Fees after staking epoch
|
|
|
|
if !st.evm.ChainConfig().IsStaking(st.evm.EpochNumber) {
|
|
|
|
txFee := new(big.Int).Mul(new(big.Int).SetUint64(st.gasUsed()), st.gasPrice)
|
|
|
|
st.state.AddBalance(st.evm.Coinbase, txFee)
|
|
|
|
}
|
|
|
|
|
|
|
|
return ExecutionResult{
|
|
|
|
ReturnData: ret,
|
|
|
|
UsedGas: st.gasUsed(),
|
|
|
|
VMErr: vmErr,
|
|
|
|
}, err
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) refundGas() {
|
|
|
|
// Apply refund counter, capped to half of the used gas.
|
|
|
|
refund := st.gasUsed() / 2
|
|
|
|
if refund > st.state.GetRefund() {
|
|
|
|
refund = st.state.GetRefund()
|
|
|
|
}
|
|
|
|
st.gas += refund
|
|
|
|
|
|
|
|
// Return ETH for remaining gas, exchanged at the original rate.
|
|
|
|
remaining := new(big.Int).Mul(new(big.Int).SetUint64(st.gas), st.gasPrice)
|
|
|
|
st.state.AddBalance(st.msg.From(), remaining)
|
|
|
|
|
|
|
|
// Also return remaining gas to the block gas counter so it is
|
|
|
|
// available for the next transaction.
|
|
|
|
st.gp.AddGas(st.gas)
|
|
|
|
}
|
|
|
|
|
|
|
|
// gasUsed returns the amount of gas used up by the state transition.
|
|
|
|
func (st *StateTransition) gasUsed() uint64 {
|
|
|
|
return st.initialGas - st.gas
|
|
|
|
}
|
|
|
|
|
|
|
|
// StakingTransitionDb will transition the state by applying the staking message and
|
|
|
|
// returning the result including the used gas. It returns an error if failed.
|
|
|
|
// It is used for staking transaction only
|
|
|
|
func (st *StateTransition) StakingTransitionDb() (usedGas uint64, err error) {
|
|
|
|
if err = st.preCheck(); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
msg := st.msg
|
|
|
|
|
|
|
|
sender := vm.AccountRef(msg.From())
|
|
|
|
homestead := st.evm.ChainConfig().IsS3(st.evm.EpochNumber) // s3 includes homestead
|
|
|
|
istanbul := st.evm.ChainConfig().IsIstanbul(st.evm.EpochNumber)
|
|
|
|
|
|
|
|
// Pay intrinsic gas
|
|
|
|
gas, err := IntrinsicGas(st.data, false, homestead, istanbul, msg.Type() == types.StakeCreateVal)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
if err = st.useGas(gas); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Increment the nonce for the next transaction
|
|
|
|
st.state.SetNonce(msg.From(), st.state.GetNonce(sender.Address())+1)
|
|
|
|
|
|
|
|
switch msg.Type() {
|
|
|
|
case types.StakeCreateVal:
|
|
|
|
stkMsg := &staking.CreateValidator{}
|
|
|
|
if err = rlp.DecodeBytes(msg.Data(), stkMsg); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
[rpc][availability][apr] Richer validator information, implement APR, unify EPoS computation, remove fall 2019 tech debt (#2484)
* [rpc][validator] Extend hmy blockchain validator information
* [availability] Optimize bump count
* [staking][validator][rpc] Remove validator stats rpc, fold into validator information, make existing pattern default behavior
* [slash] Reimplement SetDifference
* [reward][engine][network] Remove bad API from fall, begin setup for Per validator awards
* [header] Custom Marshal header for downstream, remove dev code
* [effective][committee] Factor out EPoS round of computation thereby unification in codebase of EPoS
* [unit-test] Fix semantically wrong validator unit tests, punt on maxBLS key wrt tx-pool test
* [reward] Use excellent singleflight package for caching lookup of subcommittees
* [apr][reward] Begin APR package itself, iterate on iterface signatures
* [reward] Handle possible error from singleflight
* [rpc][validator][reward] Adjust RPC committees, singleflight on votingPower, foldStats into Validator Information
* [apr] Stub out computation of APR
* [effective][committee] Upgrade SlotPurchase with named fields, provide marshal
* [effective] Update Tests
* [blockchain] TODO Remove the validators no longer in committee
* [validator][effective] More expressive string representation of eligibilty, ValidatorRPC explicit say if in committee now
* [rpc] Median-stake more semantic meaningful
* [validator] Iterate on semantic meaning of JSON representation
* [offchain] Make validator stats return explicit error
* [availability] Small typo
* [rpc] Quick visual hack until fix delete out kicked out validators
* [offchain] Delete validator from offchain that lost their slot
* [apr] Forgot to update interface signature
* [apr] Mul instead of Div
* [protocol][validator] Fold block reward accum per vaidator into validator-wrapper, off-chain => on-chain
* [votepower] Refactor votepower Roster, simplify aggregation of network wide rosters
* [votepower][shard] Adjust roster, optimize usage of BLSPublicKey as key, use MarshalText trick
* [shard] Granular errors
* [votepower][validator] Unify votepower data structure with off-chain usage
* [votepower][consensus][validator] Further simplify and unify votepower with off-chain, validator stats
* [votepower] Use RJs naming convention group,overall
* [votepower] Remove Println, do keep enforcing order
* [effective][reward] Expand semantics of eligibility as it was overloaded and confusing, evict old voting power computations
* [apr] Adjust json field name
* [votepower] Only aggregate on external validator
* [votepower] Mistake on aggregation, custom presentation network-wide
* [rpc][validator][availability] Remove parameter, take into account empty snapshot
* [apr] Use snapshots from two, one epochs ago. Still have question on header
* [apr] Use GetHeaderByNumber for the header needed for time stamp
* [chain] Evict > 3 epoch old voting power
* [blockchain] Leave Delete Validator snapshot as TODO
* [validator][rpc][effective] Undo changes to Protocol field, use virtual construct at RPC layer for meaning
* [project] Address PR comments
* [committee][rpc] Move +1 to computation of epos round rather than hack mutation
* [reward] Remove entire unnecessary loop, hook on AddReward. Remove unnecessary new big int
* [votepower][rpc][validator] Stick with numeric.Dec for token involved with computation, expose accumulate block-reward in RPC
* [effective][committee] Track the candidates for the EPoS auction, RPC median-stake benefits
* [node] Add hack way to get real error reason of why cannot load shardchain
* [consensus] Expand log on current issue on nil block
* [apr] Do the actual call to compute for validator's APR
* [committee] Wrap SlotOrder with validator address, manifests in median-stake RPC
* [apr] Incorrect error handle order
* [quorum] Remove incorrect compare on bls Key, (typo), remove redundant error check
* [shard] Add log if stakedSlots is 0
* [apr] More sanity check on div by zero, more lenient on error when dont have historical data yet
* [committee] Remove + 1 on seat count
* [apr] Use int64() directly
* [apr] Log when odd empty nil header
* [apr] Do not crash on empty header, figure out later
5 years ago
|
|
|
utils.Logger().Info().
|
|
|
|
Msgf("[DEBUG STAKING] staking type: %s, gas: %d, txn: %+v", msg.Type(), gas, stkMsg)
|
|
|
|
if msg.From() != stkMsg.ValidatorAddress {
|
|
|
|
return 0, errInvalidSigner
|
|
|
|
}
|
|
|
|
err = st.verifyAndApplyCreateValidatorTx(stkMsg, msg.BlockNum())
|
|
|
|
case types.StakeEditVal:
|
|
|
|
stkMsg := &staking.EditValidator{}
|
|
|
|
if err = rlp.DecodeBytes(msg.Data(), stkMsg); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
[rpc][availability][apr] Richer validator information, implement APR, unify EPoS computation, remove fall 2019 tech debt (#2484)
* [rpc][validator] Extend hmy blockchain validator information
* [availability] Optimize bump count
* [staking][validator][rpc] Remove validator stats rpc, fold into validator information, make existing pattern default behavior
* [slash] Reimplement SetDifference
* [reward][engine][network] Remove bad API from fall, begin setup for Per validator awards
* [header] Custom Marshal header for downstream, remove dev code
* [effective][committee] Factor out EPoS round of computation thereby unification in codebase of EPoS
* [unit-test] Fix semantically wrong validator unit tests, punt on maxBLS key wrt tx-pool test
* [reward] Use excellent singleflight package for caching lookup of subcommittees
* [apr][reward] Begin APR package itself, iterate on iterface signatures
* [reward] Handle possible error from singleflight
* [rpc][validator][reward] Adjust RPC committees, singleflight on votingPower, foldStats into Validator Information
* [apr] Stub out computation of APR
* [effective][committee] Upgrade SlotPurchase with named fields, provide marshal
* [effective] Update Tests
* [blockchain] TODO Remove the validators no longer in committee
* [validator][effective] More expressive string representation of eligibilty, ValidatorRPC explicit say if in committee now
* [rpc] Median-stake more semantic meaningful
* [validator] Iterate on semantic meaning of JSON representation
* [offchain] Make validator stats return explicit error
* [availability] Small typo
* [rpc] Quick visual hack until fix delete out kicked out validators
* [offchain] Delete validator from offchain that lost their slot
* [apr] Forgot to update interface signature
* [apr] Mul instead of Div
* [protocol][validator] Fold block reward accum per vaidator into validator-wrapper, off-chain => on-chain
* [votepower] Refactor votepower Roster, simplify aggregation of network wide rosters
* [votepower][shard] Adjust roster, optimize usage of BLSPublicKey as key, use MarshalText trick
* [shard] Granular errors
* [votepower][validator] Unify votepower data structure with off-chain usage
* [votepower][consensus][validator] Further simplify and unify votepower with off-chain, validator stats
* [votepower] Use RJs naming convention group,overall
* [votepower] Remove Println, do keep enforcing order
* [effective][reward] Expand semantics of eligibility as it was overloaded and confusing, evict old voting power computations
* [apr] Adjust json field name
* [votepower] Only aggregate on external validator
* [votepower] Mistake on aggregation, custom presentation network-wide
* [rpc][validator][availability] Remove parameter, take into account empty snapshot
* [apr] Use snapshots from two, one epochs ago. Still have question on header
* [apr] Use GetHeaderByNumber for the header needed for time stamp
* [chain] Evict > 3 epoch old voting power
* [blockchain] Leave Delete Validator snapshot as TODO
* [validator][rpc][effective] Undo changes to Protocol field, use virtual construct at RPC layer for meaning
* [project] Address PR comments
* [committee][rpc] Move +1 to computation of epos round rather than hack mutation
* [reward] Remove entire unnecessary loop, hook on AddReward. Remove unnecessary new big int
* [votepower][rpc][validator] Stick with numeric.Dec for token involved with computation, expose accumulate block-reward in RPC
* [effective][committee] Track the candidates for the EPoS auction, RPC median-stake benefits
* [node] Add hack way to get real error reason of why cannot load shardchain
* [consensus] Expand log on current issue on nil block
* [apr] Do the actual call to compute for validator's APR
* [committee] Wrap SlotOrder with validator address, manifests in median-stake RPC
* [apr] Incorrect error handle order
* [quorum] Remove incorrect compare on bls Key, (typo), remove redundant error check
* [shard] Add log if stakedSlots is 0
* [apr] More sanity check on div by zero, more lenient on error when dont have historical data yet
* [committee] Remove + 1 on seat count
* [apr] Use int64() directly
* [apr] Log when odd empty nil header
* [apr] Do not crash on empty header, figure out later
5 years ago
|
|
|
utils.Logger().Info().
|
|
|
|
Msgf("[DEBUG STAKING] staking type: %s, gas: %d, txn: %+v", msg.Type(), gas, stkMsg)
|
|
|
|
if msg.From() != stkMsg.ValidatorAddress {
|
|
|
|
return 0, errInvalidSigner
|
|
|
|
}
|
|
|
|
err = st.verifyAndApplyEditValidatorTx(stkMsg, msg.BlockNum())
|
|
|
|
case types.Delegate:
|
|
|
|
stkMsg := &staking.Delegate{}
|
|
|
|
if err = rlp.DecodeBytes(msg.Data(), stkMsg); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
utils.Logger().Info().Msgf("[DEBUG STAKING] staking type: %s, gas: %d, txn: %+v", msg.Type(), gas, stkMsg)
|
|
|
|
if msg.From() != stkMsg.DelegatorAddress {
|
|
|
|
return 0, errInvalidSigner
|
|
|
|
}
|
|
|
|
err = st.verifyAndApplyDelegateTx(stkMsg)
|
|
|
|
case types.Undelegate:
|
|
|
|
stkMsg := &staking.Undelegate{}
|
|
|
|
if err = rlp.DecodeBytes(msg.Data(), stkMsg); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
utils.Logger().Info().Msgf("[DEBUG STAKING] staking type: %s, gas: %d, txn: %+v", msg.Type(), gas, stkMsg)
|
|
|
|
if msg.From() != stkMsg.DelegatorAddress {
|
|
|
|
return 0, errInvalidSigner
|
|
|
|
}
|
|
|
|
err = st.verifyAndApplyUndelegateTx(stkMsg)
|
|
|
|
case types.CollectRewards:
|
|
|
|
stkMsg := &staking.CollectRewards{}
|
|
|
|
if err = rlp.DecodeBytes(msg.Data(), stkMsg); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
utils.Logger().Info().Msgf("[DEBUG STAKING] staking type: %s, gas: %d, txn: %+v", msg.Type(), gas, stkMsg)
|
|
|
|
if msg.From() != stkMsg.DelegatorAddress {
|
|
|
|
return 0, errInvalidSigner
|
|
|
|
}
|
|
|
|
_, err = st.verifyAndApplyCollectRewards(stkMsg)
|
|
|
|
default:
|
|
|
|
return 0, staking.ErrInvalidStakingKind
|
|
|
|
}
|
|
|
|
st.refundGas()
|
|
|
|
|
|
|
|
// Burn Txn Fees
|
|
|
|
//txFee := new(big.Int).Mul(new(big.Int).SetUint64(st.gasUsed()), st.gasPrice)
|
|
|
|
//st.state.AddBalance(st.evm.Coinbase, txFee)
|
|
|
|
|
|
|
|
return st.gasUsed(), err
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) verifyAndApplyCreateValidatorTx(
|
|
|
|
createValidator *staking.CreateValidator, blockNum *big.Int,
|
|
|
|
) error {
|
[rpc][availability][apr] Richer validator information, implement APR, unify EPoS computation, remove fall 2019 tech debt (#2484)
* [rpc][validator] Extend hmy blockchain validator information
* [availability] Optimize bump count
* [staking][validator][rpc] Remove validator stats rpc, fold into validator information, make existing pattern default behavior
* [slash] Reimplement SetDifference
* [reward][engine][network] Remove bad API from fall, begin setup for Per validator awards
* [header] Custom Marshal header for downstream, remove dev code
* [effective][committee] Factor out EPoS round of computation thereby unification in codebase of EPoS
* [unit-test] Fix semantically wrong validator unit tests, punt on maxBLS key wrt tx-pool test
* [reward] Use excellent singleflight package for caching lookup of subcommittees
* [apr][reward] Begin APR package itself, iterate on iterface signatures
* [reward] Handle possible error from singleflight
* [rpc][validator][reward] Adjust RPC committees, singleflight on votingPower, foldStats into Validator Information
* [apr] Stub out computation of APR
* [effective][committee] Upgrade SlotPurchase with named fields, provide marshal
* [effective] Update Tests
* [blockchain] TODO Remove the validators no longer in committee
* [validator][effective] More expressive string representation of eligibilty, ValidatorRPC explicit say if in committee now
* [rpc] Median-stake more semantic meaningful
* [validator] Iterate on semantic meaning of JSON representation
* [offchain] Make validator stats return explicit error
* [availability] Small typo
* [rpc] Quick visual hack until fix delete out kicked out validators
* [offchain] Delete validator from offchain that lost their slot
* [apr] Forgot to update interface signature
* [apr] Mul instead of Div
* [protocol][validator] Fold block reward accum per vaidator into validator-wrapper, off-chain => on-chain
* [votepower] Refactor votepower Roster, simplify aggregation of network wide rosters
* [votepower][shard] Adjust roster, optimize usage of BLSPublicKey as key, use MarshalText trick
* [shard] Granular errors
* [votepower][validator] Unify votepower data structure with off-chain usage
* [votepower][consensus][validator] Further simplify and unify votepower with off-chain, validator stats
* [votepower] Use RJs naming convention group,overall
* [votepower] Remove Println, do keep enforcing order
* [effective][reward] Expand semantics of eligibility as it was overloaded and confusing, evict old voting power computations
* [apr] Adjust json field name
* [votepower] Only aggregate on external validator
* [votepower] Mistake on aggregation, custom presentation network-wide
* [rpc][validator][availability] Remove parameter, take into account empty snapshot
* [apr] Use snapshots from two, one epochs ago. Still have question on header
* [apr] Use GetHeaderByNumber for the header needed for time stamp
* [chain] Evict > 3 epoch old voting power
* [blockchain] Leave Delete Validator snapshot as TODO
* [validator][rpc][effective] Undo changes to Protocol field, use virtual construct at RPC layer for meaning
* [project] Address PR comments
* [committee][rpc] Move +1 to computation of epos round rather than hack mutation
* [reward] Remove entire unnecessary loop, hook on AddReward. Remove unnecessary new big int
* [votepower][rpc][validator] Stick with numeric.Dec for token involved with computation, expose accumulate block-reward in RPC
* [effective][committee] Track the candidates for the EPoS auction, RPC median-stake benefits
* [node] Add hack way to get real error reason of why cannot load shardchain
* [consensus] Expand log on current issue on nil block
* [apr] Do the actual call to compute for validator's APR
* [committee] Wrap SlotOrder with validator address, manifests in median-stake RPC
* [apr] Incorrect error handle order
* [quorum] Remove incorrect compare on bls Key, (typo), remove redundant error check
* [shard] Add log if stakedSlots is 0
* [apr] More sanity check on div by zero, more lenient on error when dont have historical data yet
* [committee] Remove + 1 on seat count
* [apr] Use int64() directly
* [apr] Log when odd empty nil header
* [apr] Do not crash on empty header, figure out later
5 years ago
|
|
|
wrapper, err := VerifyAndCreateValidatorFromMsg(
|
|
|
|
st.state, st.bc, st.evm.EpochNumber, blockNum, createValidator,
|
[rpc][availability][apr] Richer validator information, implement APR, unify EPoS computation, remove fall 2019 tech debt (#2484)
* [rpc][validator] Extend hmy blockchain validator information
* [availability] Optimize bump count
* [staking][validator][rpc] Remove validator stats rpc, fold into validator information, make existing pattern default behavior
* [slash] Reimplement SetDifference
* [reward][engine][network] Remove bad API from fall, begin setup for Per validator awards
* [header] Custom Marshal header for downstream, remove dev code
* [effective][committee] Factor out EPoS round of computation thereby unification in codebase of EPoS
* [unit-test] Fix semantically wrong validator unit tests, punt on maxBLS key wrt tx-pool test
* [reward] Use excellent singleflight package for caching lookup of subcommittees
* [apr][reward] Begin APR package itself, iterate on iterface signatures
* [reward] Handle possible error from singleflight
* [rpc][validator][reward] Adjust RPC committees, singleflight on votingPower, foldStats into Validator Information
* [apr] Stub out computation of APR
* [effective][committee] Upgrade SlotPurchase with named fields, provide marshal
* [effective] Update Tests
* [blockchain] TODO Remove the validators no longer in committee
* [validator][effective] More expressive string representation of eligibilty, ValidatorRPC explicit say if in committee now
* [rpc] Median-stake more semantic meaningful
* [validator] Iterate on semantic meaning of JSON representation
* [offchain] Make validator stats return explicit error
* [availability] Small typo
* [rpc] Quick visual hack until fix delete out kicked out validators
* [offchain] Delete validator from offchain that lost their slot
* [apr] Forgot to update interface signature
* [apr] Mul instead of Div
* [protocol][validator] Fold block reward accum per vaidator into validator-wrapper, off-chain => on-chain
* [votepower] Refactor votepower Roster, simplify aggregation of network wide rosters
* [votepower][shard] Adjust roster, optimize usage of BLSPublicKey as key, use MarshalText trick
* [shard] Granular errors
* [votepower][validator] Unify votepower data structure with off-chain usage
* [votepower][consensus][validator] Further simplify and unify votepower with off-chain, validator stats
* [votepower] Use RJs naming convention group,overall
* [votepower] Remove Println, do keep enforcing order
* [effective][reward] Expand semantics of eligibility as it was overloaded and confusing, evict old voting power computations
* [apr] Adjust json field name
* [votepower] Only aggregate on external validator
* [votepower] Mistake on aggregation, custom presentation network-wide
* [rpc][validator][availability] Remove parameter, take into account empty snapshot
* [apr] Use snapshots from two, one epochs ago. Still have question on header
* [apr] Use GetHeaderByNumber for the header needed for time stamp
* [chain] Evict > 3 epoch old voting power
* [blockchain] Leave Delete Validator snapshot as TODO
* [validator][rpc][effective] Undo changes to Protocol field, use virtual construct at RPC layer for meaning
* [project] Address PR comments
* [committee][rpc] Move +1 to computation of epos round rather than hack mutation
* [reward] Remove entire unnecessary loop, hook on AddReward. Remove unnecessary new big int
* [votepower][rpc][validator] Stick with numeric.Dec for token involved with computation, expose accumulate block-reward in RPC
* [effective][committee] Track the candidates for the EPoS auction, RPC median-stake benefits
* [node] Add hack way to get real error reason of why cannot load shardchain
* [consensus] Expand log on current issue on nil block
* [apr] Do the actual call to compute for validator's APR
* [committee] Wrap SlotOrder with validator address, manifests in median-stake RPC
* [apr] Incorrect error handle order
* [quorum] Remove incorrect compare on bls Key, (typo), remove redundant error check
* [shard] Add log if stakedSlots is 0
* [apr] More sanity check on div by zero, more lenient on error when dont have historical data yet
* [committee] Remove + 1 on seat count
* [apr] Use int64() directly
* [apr] Log when odd empty nil header
* [apr] Do not crash on empty header, figure out later
5 years ago
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if err := st.state.UpdateValidatorWrapper(wrapper.Address, wrapper); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
st.state.SetValidatorFlag(createValidator.ValidatorAddress)
|
|
|
|
st.state.SubBalance(createValidator.ValidatorAddress, createValidator.Amount)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) verifyAndApplyEditValidatorTx(
|
|
|
|
editValidator *staking.EditValidator, blockNum *big.Int,
|
|
|
|
) error {
|
[rpc][availability][apr] Richer validator information, implement APR, unify EPoS computation, remove fall 2019 tech debt (#2484)
* [rpc][validator] Extend hmy blockchain validator information
* [availability] Optimize bump count
* [staking][validator][rpc] Remove validator stats rpc, fold into validator information, make existing pattern default behavior
* [slash] Reimplement SetDifference
* [reward][engine][network] Remove bad API from fall, begin setup for Per validator awards
* [header] Custom Marshal header for downstream, remove dev code
* [effective][committee] Factor out EPoS round of computation thereby unification in codebase of EPoS
* [unit-test] Fix semantically wrong validator unit tests, punt on maxBLS key wrt tx-pool test
* [reward] Use excellent singleflight package for caching lookup of subcommittees
* [apr][reward] Begin APR package itself, iterate on iterface signatures
* [reward] Handle possible error from singleflight
* [rpc][validator][reward] Adjust RPC committees, singleflight on votingPower, foldStats into Validator Information
* [apr] Stub out computation of APR
* [effective][committee] Upgrade SlotPurchase with named fields, provide marshal
* [effective] Update Tests
* [blockchain] TODO Remove the validators no longer in committee
* [validator][effective] More expressive string representation of eligibilty, ValidatorRPC explicit say if in committee now
* [rpc] Median-stake more semantic meaningful
* [validator] Iterate on semantic meaning of JSON representation
* [offchain] Make validator stats return explicit error
* [availability] Small typo
* [rpc] Quick visual hack until fix delete out kicked out validators
* [offchain] Delete validator from offchain that lost their slot
* [apr] Forgot to update interface signature
* [apr] Mul instead of Div
* [protocol][validator] Fold block reward accum per vaidator into validator-wrapper, off-chain => on-chain
* [votepower] Refactor votepower Roster, simplify aggregation of network wide rosters
* [votepower][shard] Adjust roster, optimize usage of BLSPublicKey as key, use MarshalText trick
* [shard] Granular errors
* [votepower][validator] Unify votepower data structure with off-chain usage
* [votepower][consensus][validator] Further simplify and unify votepower with off-chain, validator stats
* [votepower] Use RJs naming convention group,overall
* [votepower] Remove Println, do keep enforcing order
* [effective][reward] Expand semantics of eligibility as it was overloaded and confusing, evict old voting power computations
* [apr] Adjust json field name
* [votepower] Only aggregate on external validator
* [votepower] Mistake on aggregation, custom presentation network-wide
* [rpc][validator][availability] Remove parameter, take into account empty snapshot
* [apr] Use snapshots from two, one epochs ago. Still have question on header
* [apr] Use GetHeaderByNumber for the header needed for time stamp
* [chain] Evict > 3 epoch old voting power
* [blockchain] Leave Delete Validator snapshot as TODO
* [validator][rpc][effective] Undo changes to Protocol field, use virtual construct at RPC layer for meaning
* [project] Address PR comments
* [committee][rpc] Move +1 to computation of epos round rather than hack mutation
* [reward] Remove entire unnecessary loop, hook on AddReward. Remove unnecessary new big int
* [votepower][rpc][validator] Stick with numeric.Dec for token involved with computation, expose accumulate block-reward in RPC
* [effective][committee] Track the candidates for the EPoS auction, RPC median-stake benefits
* [node] Add hack way to get real error reason of why cannot load shardchain
* [consensus] Expand log on current issue on nil block
* [apr] Do the actual call to compute for validator's APR
* [committee] Wrap SlotOrder with validator address, manifests in median-stake RPC
* [apr] Incorrect error handle order
* [quorum] Remove incorrect compare on bls Key, (typo), remove redundant error check
* [shard] Add log if stakedSlots is 0
* [apr] More sanity check on div by zero, more lenient on error when dont have historical data yet
* [committee] Remove + 1 on seat count
* [apr] Use int64() directly
* [apr] Log when odd empty nil header
* [apr] Do not crash on empty header, figure out later
5 years ago
|
|
|
wrapper, err := VerifyAndEditValidatorFromMsg(
|
|
|
|
st.state, st.bc, st.evm.EpochNumber, blockNum, editValidator,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
[double-sign] Provide proof of double sign in slash record sent to beaconchain (#2253)
* [double-sign] Commit changes in consensus needed for double-sign
* [double-sign] Leader captures when valdator double signs, broadcasts to beaconchain
* [slash] Add quick iteration tool for testing double-signing
* [slash] Add webhook example
* [slash] Add http server for hook to trigger double sign behavior
* [double-sign] Use bin/trigger-double-sign to cause a double-sign
* [double-sign] Full feedback loop working
* [slash] Thread through the slash records in the block proposal step
* [slash] Compute the slashing rate
* [double-sign] Generalize yaml malicious for many keys
* [double-sign][slash] Modify data structures, verify via webhook handler
* [slash][double-sign] Find one address of bls public key signer, seemingly settle on data structures
* [slash] Apply to state slashing for double signing
* [slash][double-sign] Checkpoint for working code that slashes on beaconchain
* [slash] Keep track of the total slash and total reporters reward
* [slash] Dump account state before and after the slash
* [slash] Satisfy Travis
* [slash][state] Apply slash to the snapshot at beginning of epoch, now need to capture also the new delegates
* [slash] Capture the unique new delegations since snapshot as well
* [slash] Filter undelegation by epoch of double sign
* [slash] Add TODO of correctness needed in slash needs on off-chain data
* [rpc] Fix closure issue on shardID
* [slash] Add delegator to double-sign testing script
* [slash] Expand crt-validator.sh with commenting printfs and make delegation
* [slash] Finish track payment of leftover slash debt after undelegation runs out
* [slash] Now be explicit about error wrt delegatorSlashApply
* [slash] Capture specific sanity check on slash paidoff
* [slash] Track slash from undelegation piecemeal
* [slash][delegation] Named slice types, .String()
* [slash] Do no RLP encode twice, once is enough
* [slash] Remove special case of validators own delegation
* [slash] Refactor approach to slash state application
* [slash] Begin expanding out Verify
* [slash] Slash on snapshot delegations, not current
* [slash] Fix Epoch Cmp
* [slash] Third iteration on slash logic
* [slash] Use full slash amount
* [slash] More log, whitespace
* [slash] Remove Println, add log
* [slash] Remove debug Println
* [slash] Add record in unit test
* [slash] Build Validator snapshot, current. Fill out slash record
* [slash] Need to get RLP dump of a header to use in test
* [slash] Factor out double sign test constants
* [slash] Factor out common for validator, stub out slash application, finish out deserialization setup
* [slash] Factor out data structure creation because of var lexical scoping
* [slash] Seem to have pipeline of unit test e2e executing
* [slash] Add expected snitch, slash amounts
* [slash] Checkpoint
* [slash] Unit test correctly checks case of validator own stake which could drop below 1 ONE in slashing
* [config] add double-sign testnet config (#1)
Signed-off-by: Leo Chen <leo@harmony.one>
* [slash] Commit for as is code & data of current dump.json
* [slash] Order of state operation not correct in test, hence bad results, thank you dlv
* [slash] Add snapshot state dump
* [slash] Pay off slash of validator own delegation correctly
* [slash] Pay off slash debt with special case for min-self
* [slash] Pass first scenario conclusively
* [slash] 2% slash passes unit test for own delegation and external
* [slash] Parameterize unit test to easily test .02 vs .80 slash
* [slash] Handle own delegation correctly at 80% slash
* [slash] Have 80% slash working with external delegator
* [slash] Remove debug code from slash
* [slash] Adjust Apply signature, test again for 2% slash
* [slash] Factor out scenario in testing so can test 2% and 80% at same time
* [slash] Correct balance deduction on plan delegation
* [slash] Mock out ChainReader for TestVerify
* [slash] Small surface area interface, now feedback loop for verify
* [slash] Remove development json
* [slash] trigger-double-sign consumes yaml
* [slash] Remove dead code
* [slash][test] Factor ValidatorWrapper into scenario
* [slash][test] Add example from local-testing dump - caution might be off
* [slash] Factor out mutation of slashDebt
* [slash][test] Factor out tests so can easily load test-case from bytes
* [slash] Fix payment mistake in validator own delegation wrt min-self-delgation respected
* [slash] Satisfy Travis
* [slash] Begin cleanup of PR
* [slash] Apply slash from header to Finalize via state processor
* [slash] Productionize code, Println => logs; adjust slash picked in newblock
* [slash] Need pointer for rlp.Decode
* [slash] ValidatorInformation use full wrapper
* Fix median stake
* [staking] Adjust MarshalJSON for Validator, Wrapper
* Refactor offchain data commit; Make block onchain/offchain commit atomic (#2279)
* Refactor offchain data; Add epoch to ValidatorSnapshot
* Make block onchain/offchain data commit atomically
* [slash][committee] Set .Active to false on double sign, do not consider banned or inactive for committee assignment
* [effective] VC eligible.go
* [consensus] Redundant field in printf
* [docker] import-ks for a dev account
* [slash] Create BLS key for dockerfile and crt-validator.sh
* [slash][docker] Easy deployment of double-sign testing
* [docker] Have slash work as single docker command
* [rpc] Fix median-stake RPC
* [slash] Update webhook with default docker BLS key
* [docker][slash] Fresh yaml copy for docker build, remove dev code in main.go
* [slash] Remove helper binary, commented out code, change to local config
* [params] Factor out test genesis value
* Add shard checking to Tx-Pool & correct blacklist (#2301)
* [core] Fix blacklist & add shardID check
* [staking + node + cmd] Fix blacklist & add shardID check
* [slash] Adjust to PR comments part 1
* [docker] Use different throw away funded account
* [docker] Create easier testing for delegation with private keys
* [docker] Update yaml
* [slash] Remove special case for slashing validator own delegation wrt min-self-delegate
* [docker] Install nano as well
* [slash] Early error if banned
* [quorum] Expose earning account in decider marshal json
* Revert "Refactor offchain data commit; Make block onchain/offchain commit atomic (#2279)"
This reverts commit 9ffbf682c075b49188923c65a0bbf39ac188be00.
* [slash] Add non-sanity check way to update validator
* [reward] Increase percision on percentage in schedule
* [slash] Adjust logs
* [committee] Check eligibility of validator before doing sanity check
* [slash] Update docker
* [slash] Move create validator script to test
* [slash] More log
* [param] Make things faster
* [slash][off-chain] Clear out slashes from pending in writeblockwithstate
* [cross-link] Log is not error, just info
* [blockchain] Not necessary to guard DeletePendingSlashingCandidates
* [slash][consensus] Use plain []byte for signature b/c bls.Sign has private impl fields, rlp does not encode that
* [slash][test] Use faucet as sender, assume user imported
* [slash] Test setup
* [slash] reserve error for real error in logs
* [slash][availability] Apply availability correct, bump signing count each block
* [slash][staking] Consider banned field in sanity check, pay snitch only half of what was actually slashed
* [slash] Pay as much as can
* [slash] use right nowAmt
* [slash] Take away from rewards as well
* [slash] iterate faster
* [slash] Remove dev based timing
* [slash] Add more log, sanity check incoming slash records, only count external for slash rate
* [availability][state] Adjust signature of ValidatorWrapper wrt state, filter out for staked validators, correct availaibility measure on running counters
* [availability] More log
* [slash] Simply pre slash erra slashing
* [slash] Remove development code
* [slash] Use height from recvMsg, todo on epoch
* [staking] Not necessary to touch LastEpochInCommittee in staking_verifier
* [slash] Undo ds in endpoint pattern config
* [slash] Add TODO and log when delegation becomes 0 b/c slash debt payment
* [slash] Abstract staked validators from shard.State into type, set slash rate based BLSKey count
Co-authored-by: Leo Chen <leo@harmony.one>
Co-authored-by: flicker-harmony <52401354+flicker-harmony@users.noreply.github.com>
Co-authored-by: Rongjian Lan <rongjian@harmony.one>
Co-authored-by: Daniel Van Der Maden <daniel@harmony.one>
5 years ago
|
|
|
return st.state.UpdateValidatorWrapper(wrapper.Address, wrapper)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) verifyAndApplyDelegateTx(delegate *staking.Delegate) error {
|
|
|
|
delegations, err := st.bc.ReadDelegationsByDelegator(delegate.DelegatorAddress)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
updatedValidatorWrappers, balanceToBeDeducted, fromLockedTokens, err := VerifyAndDelegateFromMsg(
|
|
|
|
st.state, st.evm.EpochNumber, delegate, delegations, st.evm.ChainConfig())
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, wrapper := range updatedValidatorWrappers {
|
|
|
|
if err := st.state.UpdateValidatorWrapper(wrapper.Address, wrapper); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
st.state.SubBalance(delegate.DelegatorAddress, balanceToBeDeducted)
|
|
|
|
|
|
|
|
if len(fromLockedTokens) > 0 {
|
|
|
|
sortedKeys := []common.Address{}
|
|
|
|
for key := range fromLockedTokens {
|
|
|
|
sortedKeys = append(sortedKeys, key)
|
|
|
|
}
|
|
|
|
sort.SliceStable(sortedKeys, func(i, j int) bool {
|
|
|
|
return bytes.Compare(sortedKeys[i][:], sortedKeys[j][:]) < 0
|
|
|
|
})
|
|
|
|
// Add log if everything is good
|
|
|
|
for _, key := range sortedKeys {
|
|
|
|
redelegatedToken, ok := fromLockedTokens[key]
|
|
|
|
if !ok {
|
|
|
|
return errors.New("Key missing for delegation receipt")
|
|
|
|
}
|
|
|
|
encodedRedelegationData := []byte{}
|
|
|
|
addrBytes := key.Bytes()
|
|
|
|
encodedRedelegationData = append(encodedRedelegationData, addrBytes...)
|
|
|
|
encodedRedelegationData = append(encodedRedelegationData, redelegatedToken.Bytes()...)
|
|
|
|
// The data field format is:
|
|
|
|
// [first 20 bytes]: Validator address from which the locked token is used for redelegation.
|
|
|
|
// [rest of the bytes]: the bigInt serialized bytes for the token amount.
|
|
|
|
st.state.AddLog(&types.Log{
|
|
|
|
Address: delegate.DelegatorAddress,
|
|
|
|
Topics: []common.Hash{staking2.DelegateTopic},
|
|
|
|
Data: encodedRedelegationData,
|
|
|
|
BlockNumber: st.evm.BlockNumber.Uint64(),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
[rpc][availability][apr] Richer validator information, implement APR, unify EPoS computation, remove fall 2019 tech debt (#2484)
* [rpc][validator] Extend hmy blockchain validator information
* [availability] Optimize bump count
* [staking][validator][rpc] Remove validator stats rpc, fold into validator information, make existing pattern default behavior
* [slash] Reimplement SetDifference
* [reward][engine][network] Remove bad API from fall, begin setup for Per validator awards
* [header] Custom Marshal header for downstream, remove dev code
* [effective][committee] Factor out EPoS round of computation thereby unification in codebase of EPoS
* [unit-test] Fix semantically wrong validator unit tests, punt on maxBLS key wrt tx-pool test
* [reward] Use excellent singleflight package for caching lookup of subcommittees
* [apr][reward] Begin APR package itself, iterate on iterface signatures
* [reward] Handle possible error from singleflight
* [rpc][validator][reward] Adjust RPC committees, singleflight on votingPower, foldStats into Validator Information
* [apr] Stub out computation of APR
* [effective][committee] Upgrade SlotPurchase with named fields, provide marshal
* [effective] Update Tests
* [blockchain] TODO Remove the validators no longer in committee
* [validator][effective] More expressive string representation of eligibilty, ValidatorRPC explicit say if in committee now
* [rpc] Median-stake more semantic meaningful
* [validator] Iterate on semantic meaning of JSON representation
* [offchain] Make validator stats return explicit error
* [availability] Small typo
* [rpc] Quick visual hack until fix delete out kicked out validators
* [offchain] Delete validator from offchain that lost their slot
* [apr] Forgot to update interface signature
* [apr] Mul instead of Div
* [protocol][validator] Fold block reward accum per vaidator into validator-wrapper, off-chain => on-chain
* [votepower] Refactor votepower Roster, simplify aggregation of network wide rosters
* [votepower][shard] Adjust roster, optimize usage of BLSPublicKey as key, use MarshalText trick
* [shard] Granular errors
* [votepower][validator] Unify votepower data structure with off-chain usage
* [votepower][consensus][validator] Further simplify and unify votepower with off-chain, validator stats
* [votepower] Use RJs naming convention group,overall
* [votepower] Remove Println, do keep enforcing order
* [effective][reward] Expand semantics of eligibility as it was overloaded and confusing, evict old voting power computations
* [apr] Adjust json field name
* [votepower] Only aggregate on external validator
* [votepower] Mistake on aggregation, custom presentation network-wide
* [rpc][validator][availability] Remove parameter, take into account empty snapshot
* [apr] Use snapshots from two, one epochs ago. Still have question on header
* [apr] Use GetHeaderByNumber for the header needed for time stamp
* [chain] Evict > 3 epoch old voting power
* [blockchain] Leave Delete Validator snapshot as TODO
* [validator][rpc][effective] Undo changes to Protocol field, use virtual construct at RPC layer for meaning
* [project] Address PR comments
* [committee][rpc] Move +1 to computation of epos round rather than hack mutation
* [reward] Remove entire unnecessary loop, hook on AddReward. Remove unnecessary new big int
* [votepower][rpc][validator] Stick with numeric.Dec for token involved with computation, expose accumulate block-reward in RPC
* [effective][committee] Track the candidates for the EPoS auction, RPC median-stake benefits
* [node] Add hack way to get real error reason of why cannot load shardchain
* [consensus] Expand log on current issue on nil block
* [apr] Do the actual call to compute for validator's APR
* [committee] Wrap SlotOrder with validator address, manifests in median-stake RPC
* [apr] Incorrect error handle order
* [quorum] Remove incorrect compare on bls Key, (typo), remove redundant error check
* [shard] Add log if stakedSlots is 0
* [apr] More sanity check on div by zero, more lenient on error when dont have historical data yet
* [committee] Remove + 1 on seat count
* [apr] Use int64() directly
* [apr] Log when odd empty nil header
* [apr] Do not crash on empty header, figure out later
5 years ago
|
|
|
func (st *StateTransition) verifyAndApplyUndelegateTx(
|
|
|
|
undelegate *staking.Undelegate,
|
|
|
|
) error {
|
|
|
|
wrapper, err := VerifyAndUndelegateFromMsg(st.state, st.evm.EpochNumber, undelegate)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
return st.state.UpdateValidatorWrapper(wrapper.Address, wrapper)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (st *StateTransition) verifyAndApplyCollectRewards(collectRewards *staking.CollectRewards) (*big.Int, error) {
|
|
|
|
if st.bc == nil {
|
|
|
|
return stakingReward.None, errors.New("[CollectRewards] No chain context provided")
|
|
|
|
}
|
|
|
|
delegations, err := st.bc.ReadDelegationsByDelegator(collectRewards.DelegatorAddress)
|
|
|
|
if err != nil {
|
|
|
|
return stakingReward.None, err
|
|
|
|
}
|
[double-sign] Provide proof of double sign in slash record sent to beaconchain (#2253)
* [double-sign] Commit changes in consensus needed for double-sign
* [double-sign] Leader captures when valdator double signs, broadcasts to beaconchain
* [slash] Add quick iteration tool for testing double-signing
* [slash] Add webhook example
* [slash] Add http server for hook to trigger double sign behavior
* [double-sign] Use bin/trigger-double-sign to cause a double-sign
* [double-sign] Full feedback loop working
* [slash] Thread through the slash records in the block proposal step
* [slash] Compute the slashing rate
* [double-sign] Generalize yaml malicious for many keys
* [double-sign][slash] Modify data structures, verify via webhook handler
* [slash][double-sign] Find one address of bls public key signer, seemingly settle on data structures
* [slash] Apply to state slashing for double signing
* [slash][double-sign] Checkpoint for working code that slashes on beaconchain
* [slash] Keep track of the total slash and total reporters reward
* [slash] Dump account state before and after the slash
* [slash] Satisfy Travis
* [slash][state] Apply slash to the snapshot at beginning of epoch, now need to capture also the new delegates
* [slash] Capture the unique new delegations since snapshot as well
* [slash] Filter undelegation by epoch of double sign
* [slash] Add TODO of correctness needed in slash needs on off-chain data
* [rpc] Fix closure issue on shardID
* [slash] Add delegator to double-sign testing script
* [slash] Expand crt-validator.sh with commenting printfs and make delegation
* [slash] Finish track payment of leftover slash debt after undelegation runs out
* [slash] Now be explicit about error wrt delegatorSlashApply
* [slash] Capture specific sanity check on slash paidoff
* [slash] Track slash from undelegation piecemeal
* [slash][delegation] Named slice types, .String()
* [slash] Do no RLP encode twice, once is enough
* [slash] Remove special case of validators own delegation
* [slash] Refactor approach to slash state application
* [slash] Begin expanding out Verify
* [slash] Slash on snapshot delegations, not current
* [slash] Fix Epoch Cmp
* [slash] Third iteration on slash logic
* [slash] Use full slash amount
* [slash] More log, whitespace
* [slash] Remove Println, add log
* [slash] Remove debug Println
* [slash] Add record in unit test
* [slash] Build Validator snapshot, current. Fill out slash record
* [slash] Need to get RLP dump of a header to use in test
* [slash] Factor out double sign test constants
* [slash] Factor out common for validator, stub out slash application, finish out deserialization setup
* [slash] Factor out data structure creation because of var lexical scoping
* [slash] Seem to have pipeline of unit test e2e executing
* [slash] Add expected snitch, slash amounts
* [slash] Checkpoint
* [slash] Unit test correctly checks case of validator own stake which could drop below 1 ONE in slashing
* [config] add double-sign testnet config (#1)
Signed-off-by: Leo Chen <leo@harmony.one>
* [slash] Commit for as is code & data of current dump.json
* [slash] Order of state operation not correct in test, hence bad results, thank you dlv
* [slash] Add snapshot state dump
* [slash] Pay off slash of validator own delegation correctly
* [slash] Pay off slash debt with special case for min-self
* [slash] Pass first scenario conclusively
* [slash] 2% slash passes unit test for own delegation and external
* [slash] Parameterize unit test to easily test .02 vs .80 slash
* [slash] Handle own delegation correctly at 80% slash
* [slash] Have 80% slash working with external delegator
* [slash] Remove debug code from slash
* [slash] Adjust Apply signature, test again for 2% slash
* [slash] Factor out scenario in testing so can test 2% and 80% at same time
* [slash] Correct balance deduction on plan delegation
* [slash] Mock out ChainReader for TestVerify
* [slash] Small surface area interface, now feedback loop for verify
* [slash] Remove development json
* [slash] trigger-double-sign consumes yaml
* [slash] Remove dead code
* [slash][test] Factor ValidatorWrapper into scenario
* [slash][test] Add example from local-testing dump - caution might be off
* [slash] Factor out mutation of slashDebt
* [slash][test] Factor out tests so can easily load test-case from bytes
* [slash] Fix payment mistake in validator own delegation wrt min-self-delgation respected
* [slash] Satisfy Travis
* [slash] Begin cleanup of PR
* [slash] Apply slash from header to Finalize via state processor
* [slash] Productionize code, Println => logs; adjust slash picked in newblock
* [slash] Need pointer for rlp.Decode
* [slash] ValidatorInformation use full wrapper
* Fix median stake
* [staking] Adjust MarshalJSON for Validator, Wrapper
* Refactor offchain data commit; Make block onchain/offchain commit atomic (#2279)
* Refactor offchain data; Add epoch to ValidatorSnapshot
* Make block onchain/offchain data commit atomically
* [slash][committee] Set .Active to false on double sign, do not consider banned or inactive for committee assignment
* [effective] VC eligible.go
* [consensus] Redundant field in printf
* [docker] import-ks for a dev account
* [slash] Create BLS key for dockerfile and crt-validator.sh
* [slash][docker] Easy deployment of double-sign testing
* [docker] Have slash work as single docker command
* [rpc] Fix median-stake RPC
* [slash] Update webhook with default docker BLS key
* [docker][slash] Fresh yaml copy for docker build, remove dev code in main.go
* [slash] Remove helper binary, commented out code, change to local config
* [params] Factor out test genesis value
* Add shard checking to Tx-Pool & correct blacklist (#2301)
* [core] Fix blacklist & add shardID check
* [staking + node + cmd] Fix blacklist & add shardID check
* [slash] Adjust to PR comments part 1
* [docker] Use different throw away funded account
* [docker] Create easier testing for delegation with private keys
* [docker] Update yaml
* [slash] Remove special case for slashing validator own delegation wrt min-self-delegate
* [docker] Install nano as well
* [slash] Early error if banned
* [quorum] Expose earning account in decider marshal json
* Revert "Refactor offchain data commit; Make block onchain/offchain commit atomic (#2279)"
This reverts commit 9ffbf682c075b49188923c65a0bbf39ac188be00.
* [slash] Add non-sanity check way to update validator
* [reward] Increase percision on percentage in schedule
* [slash] Adjust logs
* [committee] Check eligibility of validator before doing sanity check
* [slash] Update docker
* [slash] Move create validator script to test
* [slash] More log
* [param] Make things faster
* [slash][off-chain] Clear out slashes from pending in writeblockwithstate
* [cross-link] Log is not error, just info
* [blockchain] Not necessary to guard DeletePendingSlashingCandidates
* [slash][consensus] Use plain []byte for signature b/c bls.Sign has private impl fields, rlp does not encode that
* [slash][test] Use faucet as sender, assume user imported
* [slash] Test setup
* [slash] reserve error for real error in logs
* [slash][availability] Apply availability correct, bump signing count each block
* [slash][staking] Consider banned field in sanity check, pay snitch only half of what was actually slashed
* [slash] Pay as much as can
* [slash] use right nowAmt
* [slash] Take away from rewards as well
* [slash] iterate faster
* [slash] Remove dev based timing
* [slash] Add more log, sanity check incoming slash records, only count external for slash rate
* [availability][state] Adjust signature of ValidatorWrapper wrt state, filter out for staked validators, correct availaibility measure on running counters
* [availability] More log
* [slash] Simply pre slash erra slashing
* [slash] Remove development code
* [slash] Use height from recvMsg, todo on epoch
* [staking] Not necessary to touch LastEpochInCommittee in staking_verifier
* [slash] Undo ds in endpoint pattern config
* [slash] Add TODO and log when delegation becomes 0 b/c slash debt payment
* [slash] Abstract staked validators from shard.State into type, set slash rate based BLSKey count
Co-authored-by: Leo Chen <leo@harmony.one>
Co-authored-by: flicker-harmony <52401354+flicker-harmony@users.noreply.github.com>
Co-authored-by: Rongjian Lan <rongjian@harmony.one>
Co-authored-by: Daniel Van Der Maden <daniel@harmony.one>
5 years ago
|
|
|
updatedValidatorWrappers, totalRewards, err := VerifyAndCollectRewardsFromDelegation(
|
|
|
|
st.state, delegations,
|
|
|
|
)
|
|
|
|
if err != nil {
|
|
|
|
return stakingReward.None, err
|
|
|
|
}
|
|
|
|
for _, wrapper := range updatedValidatorWrappers {
|
|
|
|
if err := st.state.UpdateValidatorWrapper(wrapper.Address, wrapper); err != nil {
|
|
|
|
return stakingReward.None, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
st.state.AddBalance(collectRewards.DelegatorAddress, totalRewards)
|
|
|
|
|
|
|
|
// Add log if everything is good
|
|
|
|
st.state.AddLog(&types.Log{
|
|
|
|
Address: collectRewards.DelegatorAddress,
|
|
|
|
Topics: []common.Hash{staking2.CollectRewardsTopic},
|
|
|
|
Data: totalRewards.Bytes(),
|
|
|
|
BlockNumber: st.evm.BlockNumber.Uint64(),
|
|
|
|
})
|
|
|
|
|
|
|
|
return totalRewards, nil
|
|
|
|
}
|