sacrifice differentiating between wp note added and wp edited for speed

Instead of differentiating between the user having added a note and the
user having altered the wp's attributes, we always return the same icon
in the activity.

This allows us to not n+1 fetch the event journal and it's predecessor.

app/models/activity/work_package_activity_provider.rb

@@ -62,14 +62,7 @@ class Activity::WorkPackageActivityProvider < Activity::BaseActivityProvider
   end
 
   def event_type(event, _activity)
-    state = ''
-    journal = Journal.find(event['event_id'])
-
-    if journal.details.empty? && !journal.initial?
-      state = '-note'
-    else
     state = ActiveRecord::Type::Boolean.new.cast(event['status_closed']) ? '-closed' : '-edit'
-    end
 
     "work_package#{state}"
   end