openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	64cf18856b	Revert "update locales from crowdin [ci skip]" This reverts commit `3cb8fef5e6`.	4 years ago
Travis CI User	3cb8fef5e6	update locales from crowdin [ci skip]	4 years ago
Travis CI User	9187f43935	update locales from crowdin [ci skip]	4 years ago
Travis CI User	31b0931892	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	0a84a0b671	[36296] Add PlaceholderUsers API (#9033 ) * Add PlaceholderUsers API * Fix remarks in apib * Add deduce_element_decorator to collection * Remove unnecessary path	4 years ago
ulferts	609d6e04a6	Fix/bump gems (#9039 ) * bump excon * bump faker * bump fastimage * bump pdf-reader * bump okcomputer * bump recaptcha * bump rspec-mocks * bump ruby-prof * bump webmock * bump rack-mini-profiler * bump mime-types-data * bump timecop * bump test-prof	4 years ago
ulferts	b8ca382d34	Group API (#9034 ) * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
ulferts	b5f016648e	bump aws-sdk-sns	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012 ) * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
Oliver Günther	d1c9c32fa0	Remove ldap group memberships when user is destroyed (#9037 )	4 years ago
Oliver Günther	4980b4fb4a	Allow LDAP filters and groups to individually sync users (#9031 )	4 years ago
Travis CI User	db41c16229	update locales from crowdin [ci skip]	4 years ago
Travis CI User	272141f69a	update locales from crowdin [ci skip]	4 years ago
Travis CI User	aba74d6211	update locales from crowdin [ci skip]	4 years ago
Travis CI User	40d0fa19ce	update locales from crowdin [ci skip]	4 years ago
Travis CI User	1135cb0ddf	update locales from crowdin [ci skip]	4 years ago
Travis CI User	553f1382a0	update locales from crowdin [ci skip]	4 years ago
ulferts	049f3cb6f5	avoid static ids in spec	4 years ago
Travis CI User	ec555b0398	update locales from crowdin [ci skip]	4 years ago
Travis CI User	204cfe7bdf	update locales from crowdin [ci skip]	4 years ago
Markus Kahl	863d227d4b	hcaptcha support (#9022 )	4 years ago
Travis CI User	635e9fcabe	update locales from crowdin [ci skip]	4 years ago
Travis CI User	3e239df370	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	0b0066d81e	Correct spec for dashboards It was moved to the dashboards module but not properly rewritten	4 years ago
Oliver Günther	05fc4c45ae	Add common op-principal component and service to render The service renders just like avatars for users outside angular as it will also be used for rendering group and placeholder "avatars" and replace the UserAvatar render service.	4 years ago
Travis CI User	f028241b61	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b4dfc50803	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007 ) * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	5f8a9a1868	[35157] Fix backlogs settings validations to disallow task = story (#9009 ) Refactors the settings controller into its own controller to allow checking the parameters before saving. Also removes a JS snippet that is no longer being executed since CSP is enforced. https://community.openproject.com/wp/35157	4 years ago
Aleix Suau	8dd5ebfc9f	Fix/34840 filter out not allowed board lists (#8983 ) * Refactor * Added pageSize=0 to make the calls lighter * Refactor * Added pageSize=0 to make the calls lighter * Safe operator on board.queries * Tests failing * Tests failing * Debugging failing test * fix setting up the tests * continue integration test on board error messages * linting Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Travis CI User	79f5e33924	update locales from crowdin [ci skip]	4 years ago
Travis CI User	2e498cebd9	update locales from crowdin [ci skip]	4 years ago
Travis CI User	860b5c4213	update locales from crowdin [ci skip]	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	cb5fbb6a72	Use the configured variable for expiry https://github.com/opf/openproject/pull/8941	4 years ago
Oliver Günther	8df966abff	Use the configured variable for expiry (#8985 ) https://github.com/opf/openproject/pull/8941	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Travis CI User	7ccc01d091	update locales from crowdin [ci skip]	4 years ago
Travis CI User	62351cd8b2	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
Oliver Günther	90d8dec296	Rewrite duplicated CreateService specs (#8959 ) * Add common base service create service examples * Rewrite user service spec into the common service * Rewrite CustomFields::CreateService spec into common * Rewrite Messages::CreateService into common * Rewrite Projects::CreateService with common example * Rewrite Grids::CreateService spec with common examples * Rewrite BIM::IfcModels::CreateService with common examples * Rewrite Bim::Bcf::Issues::CreateService with new common examples	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
Philipp Tessenow	a8bbbdcf5a	Fixed metadata and a typo in our GitHub Plugin (#8970 ) * Fixed metadata and a typo in our GitHub Plugin I found these while reviewing the code. Probably doesn't hurt to fix even tiny things like these :) https://community.openproject.com/projects/openproject/work_packages/36150 * Update modules/github_integration/lib/open_project/github_integration/engine.rb thanks @lindenthal	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948 ) * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
ulferts	3157dd0d0b	Fix/bump gems (#8950 ) * bump bootsnap * bump brakeman * bump capybara * bump aws-partitions * bump oj * bump puma * bump rubocop * remove order based expectation on spec	4 years ago

1 2 3 4 5 ...

2346 Commits (28a8b4f78c2548f68d6e7085621ca269bf5fbe76)