openproject

Commit Graph

Author	SHA1	Message	Date
OpenProject Actions CI	ecbb81b5a6	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	65dc28d913	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	8b763cb038	update locales from crowdin [ci skip]	4 years ago
Philipp Tessenow	bd906716e5	[#36153 ] link manually created pull request to a work package using the GitHub integration plug-in (#9070 ) * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment	4 years ago
OpenProject Actions CI	8c44d99d76	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157 ) * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
OpenProject Actions CI	a75ff8534e	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	4f6ea6fbf0	update locales from crowdin [ci skip]	4 years ago
Philipp Tessenow	fd19962429	Fixing a flaky specs in the github integration feature specs (#9151 ) Sorry for introducing it, it was a false assumption about how work package subjects are generated in the factory. Turns out it is more stable and a better test to specify the subject we test in the test setup itself anyways.	4 years ago
OpenProject Actions CI	d376ab92dd	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	3dedf3dea4	update locales from crowdin [ci skip]	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago
OpenProject Actions CI	cc3ee5a40d	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	ebbe5ec584	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	693d01f8c7	Bump Sentry and implement log handling in core (#9133 ) * Bump Sentry and implement log handling in core * Manually insert the sentry middlewares * Also add user locale as tags * Add performance tracing * Update sentry host to sentry2 * Update frontend sentry-reporter to the new sdk * Silence delayed_job's own logger since activejob logs already Delayed::Job will otherwise always log all arguments, which we disable by design * Remove default sentry host	4 years ago
Oliver Günther	26acf03e7a	Add schema location attribute (#9140 ) * Extend schema with a location property * Extend specs to test for location presence * Document location property * Fix typo Co-authored-by: Philipp Tessenow <tessi@bitcrowd.net> Co-authored-by: Philipp Tessenow <tessi@bitcrowd.net>	4 years ago
Benjamin Bädorf	2667cd1581	Refactor/app header (#9110 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Basic BEM changes * Remove old classes * Update more classes * Update togling logic * Fixed menu opening and some styles * Added op-menu * Fix some help menu styles * Add op-menu to help menug * Add avatar border * Fix auth_provider_spec * Fix zen mode * Fix static link help menu * Fixed top menu specs * Fix self registration specs * Fix logout spec * Fix bim revit navigation spec * Fixed menu permissions spec * Fix homescreen onboarding tour spec * Fix top menu item spec * Remove unused file * Fix a lot of mobile styles * Fix more mobile styles * Fixed build * Move quick add menu to right hand side * Improve quick-add-button styles, fix main-menu-toggle close icon * Remove add new project spec * Fix spec * Update project dropdown styles * Fix click handler for chrome mobile, update some styles Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
OpenProject Actions CI	921d4db8c8	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	c7e3d21a0b	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	8b2112f543	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	ffee103de7	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	809a5b563a	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	e675848681	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	75d7aec277	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	adb3691ab3	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	0a588209cf	update locales from crowdin [ci skip]	4 years ago
ulferts	4bf7a26eb1	Capabilities API (#9083 ) * Capabilities API * introduce auxilliary capability model * capability model and query * render in sql * fix pagination * introduce sql representer * extract abstract sql representer class * remove yet unused methods * abstract sql collection representer * contract_actions as part of permissions * filter for capability id - used in GET * id filter validation * remove unused representer * remove unused wp representer * reuse renaming class * add spec for access control * add principal filter to capability * add context filter * extract capability sql into scope * admin gets all capabilities * require to have one filter set to keep performance bearable * consider active project modules for capabilities * limit capability based on principal visiblity and user state * rework capability to be tableless * spec not being allowed to see on request level * add actions to capability representer * add action api * extract sql index endpoint * remove unused class * prepare sending signaling error - not yet frontend exposed * extract show endpoint for sql rendered responses * use UNION for better performance * include navigation links on collections * remove string replacements * extract collection representer into hal sql module * no capabilities when blocked * remove commented out code	4 years ago
Oliver Günther	57034bc7d6	[35744] Use case-insenstive string comparison for action boards (#9112 ) https://community.openproject.com/work_packages/35744	4 years ago
Oliver Günther	6d38de10b3	Fix empty story in backlogs https://sentry.openproject.com/sentry/saas-openproject-prod/issues/12414/	4 years ago
ulferts	94fe889ba7	Fix/bump gems (#9106 ) * bump activerecord-session_store * bump oj * bump danger * bump rspec-rails * bump i18n-js * bump faker * bump aws-sdk-core * bump aws-sdk-kms * bump aws-sdk-s3 * bump aws-sdk-sns * bump icalendar	4 years ago
Oliver Günther	dfe575ca9c	[36269] Add "other" to pluralization rules for one (#9102 ) * [36269] Add "other" to pluralization rules for one For languages that do not have "one" as a pluralization rule (japanese, for example), the pluralization rule defined by I18n.js does not return a valid string for count: 1. Since we probably do not want to define custom pluralization rules for all languages, we can fall back to the "other" key if "one" is not defined. https://community.openproject.com/wp/36269 * Explicitly wait before clicking on viewpoint The click happens before the side tree is rendered by xeokit, and not being updated afterwards	4 years ago
Oliver Günther	1d163f93bb	Move retry block outside checkbox selector	4 years ago
Oliver Günther	3fb0504c98	[36425] Fix and localize contact us for demo link (#9100 ) https://community.openproject.com/wp/36425	4 years ago
Benjamin Bädorf	beb4e6ba50	Refactor/user avatar to principal (#9069 ) * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Update user-avatar usages to principal * Fix some op-principal usages * Fix principal typing * Remove ls of non-existent directory * Rename more user-avatar instances * Avatars now render correctly * Fix an op-principal instance, default to avatar class for avatars * Always add principal id to default principal tag * Small fixes to op-principal * Fix multiline user display * Dirty fix for capybara click events * Update avatar sizing * Fixed some specs * Fix unit specs * Added op-link styles * Fix add placeholder image link * Remove byebug debugger statements Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Aleix Suau	3569dbe8f0	Timing issue solved with retry_block	4 years ago
Aleix Suau	2b07cb2d23	Timing issue solved with retry_block	4 years ago
ulferts	a64c77c1be	avoid test flickering by having more complex password	4 years ago
Oliver Günther	3b78be087b	Migrate tslint to eslint (#9064 ) * tslint to eslint migration * Autofix issues * Fix codeclimate path to eslintrc * Extend linter config for use with ng lint * Change prefix to op in angular lints	4 years ago
ulferts	f0cf90d7e1	Fix the rails cell not using the content_tag helper of ActionView with escaping (#9067 ) * fixes show links for project members * Properly escapes the name. The cells gem does not escape strings unlike rails * Fixes the case statement for links and includes the link for placeholder users * Fix escaping of content_tag in rails cell and add spec for that Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
Oliver Günther	ea29493ce7	[36353] Restrict possible select options in cost entries to users (#9053 ) https://community.openproject.com/wp/36353	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977 ) * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
Oliver Günther	c7263412f1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	5efea5cf81	update locales from crowdin [ci skip]	4 years ago
ulferts	64cf18856b	Revert "update locales from crowdin [ci skip]" This reverts commit `3cb8fef5e6`.	4 years ago
Travis CI User	3cb8fef5e6	update locales from crowdin [ci skip]	4 years ago
Travis CI User	9187f43935	update locales from crowdin [ci skip]	4 years ago
Travis CI User	31b0931892	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	0a84a0b671	[36296] Add PlaceholderUsers API (#9033 ) * Add PlaceholderUsers API * Fix remarks in apib * Add deduce_element_decorator to collection * Remove unnecessary path	4 years ago
ulferts	609d6e04a6	Fix/bump gems (#9039 ) * bump excon * bump faker * bump fastimage * bump pdf-reader * bump okcomputer * bump recaptcha * bump rspec-mocks * bump ruby-prof * bump webmock * bump rack-mini-profiler * bump mime-types-data * bump timecop * bump test-prof	4 years ago

1 2 3 4 5 ...

2396 Commits (3d41a820111b31466450db1cbbef09f8982afc2c)