openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	6763fe875d	Remove save button for managed repositories This commit removes the settings `save` button for managed repositories. Important: When adjustable settings for any vendor should be added, this button must be shown depending on some individual vendor logic.	9 years ago
Oliver Günther	325ddf6fb3	Fix skipped legacy spec due to removed subversion test directory	9 years ago
Oliver Günther	ad0632a278	Fix invalid method used in :update	9 years ago
Oliver Günther	5cb81d6995	Fix typo in attributes-group.	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Oliver Günther	ca04363e6d	Allow to delete filesystem managed repositories even when config missing Previously, repositories could not be deleted on disk when the `manages:` configuration entry was removed in the meantime. This commit allows repositories to be deleted in that case because we no longer depend on accessing the managed_root (path for `manages:`).	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Oliver Günther	9336cff8bb	Extended specs This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	3f347fdc25	Refactor attribute-groups to use -toggleable modifier instead	9 years ago
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	35c78a6acc	Remove superfluous JS remote select.	9 years ago
Oliver Günther	ddfb07659a	Added description to configuration.yml.example. This changes the configuration example to the new format, which allows to enable managed repositories for a custom selection of vendors.	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	c63b9c7a08	Frontend refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user.	9 years ago
Oliver Günther	3377696563	Began frontend feature specs	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	2ce4646346	Reverted implied annotate bugfix which raised more questions Annotation syntax highlighting was broken and I fixed it, this commit reverts the changes, which will be properly re-addressed in the separated PR: https://github.com/opf/openproject/pull/3250	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	15d026081b	Convert repository fixtures for compatibility. Travis build system still runs Ubuntu 12.04., which includes subversion 1.6.17. Rather than introducing a whole new PPA to travis, this commit converts the new subversion test fixture to pre-1.6 compatibility. Also, OSX's bsdtar uses `._*` member files for special meaning, which will lead to filesystem specs reporting incorrect size on a Linux system. To circumvent this, filesystem fixture has been re-packed with `COPYFILE_DISABLE=1` (c.f., http://superuser.com/questions/61185)	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Florian Kraft	4a155d267e	Merge pull request #3266 from oliverguenther/feature/severe_warnings_style [ci skip] Allow notification-box.warning to be severe without being a…	9 years ago
Oliver Günther	a7f7f925f8	[ci skip] Allow notification-box.warning to be severe without being an error. In the review of https://github.com/opf/openproject/pull/3196, a notification box with error style was used to communicate a warning prior to repository deletion with severe consequences (removal of files outside OpenProject). This commit suggests to add a `-severe` switch to warning notifications to signal such a severe decision while NOT being an error. The implementation re-uses the error colors (as red is often used to communicate severe warnings - cf. GitHub danger zone, Bootstrap styles). I envision this notification to be used in other aspects of the application, with at least project destroy_info to be of the same severity that I argue this to be included in the core. Relevant work package: https://community.openproject.org/work_packages/20999	9 years ago
Jens Ulferts	63539001f0	Merge branch 'release/4.2' into release/4.3	9 years ago
Jens Ulferts	a21335db36	safeguard spec	9 years ago
Jens Ulferts	c5de9a4fb7	move spec shared context up in the dir hierarchy	9 years ago
Jens Ulferts	751751f6b4	reuse safeguards for wp index loaded in specs	9 years ago
Jens Ulferts	afd5d7275d	Merge branch 'release/4.2' into release/4.3	9 years ago
Jens Ulferts	d5f44a0c60	hoping to fix spec with the help of ng_wait	9 years ago
Jonas Heinrich	d89f9e772a	Merge branch 'release/4.2' into release/4.3	9 years ago
jonasheinrich	85d37e9e1c	Merge pull request #3259 from kgalli/fix/update_installation_guide Update guide to current installation dependencies	9 years ago
kgalli	753e3605d8	Replacement of analogous with similarly	9 years ago
kgalli	a731ade28d	Fix for a lot of typos	9 years ago
kgalli	0f98e004c2	Update guide to current installation dependencies This guide also introduces rbanv and nodenv as replacement for rvm and nvm.	9 years ago
ulferts	fe00b85372	Merge pull request #3256 from oliverguenther/fix/module_menu_permissions Hide the module menu when user is anonymous and login is required.	9 years ago
Oliver Günther	165e56c7ed	Hide the module menu when user is anonymous and login is required. The public permission of `:view_news` causes the Module menu to always render when the user is anonymous, even when the Setting `login_required` is enabled. This workaround hides the module menu in this specific case. Relevant work package: https://community.openproject.org/work_packages/20935	9 years ago
ulferts	4b47a13f2d	Merge pull request #3247 from NobodysNightmare/feature/fix_inconsistent_journals Add unique index over journals(journable_type, journable_id, version)	9 years ago
Jens Ulferts	178e22ab58	Merge branch 'release/4.2' into release/4.3	9 years ago
ulferts	a5432dadf4	Merge pull request #3255 from jonasheinrich/feature/how_to_spec_all Adds a how to test all specs	9 years ago
Jonas Heinrich	38d6e644ad	Adapt version to corresponding OpenProject core version.	9 years ago
jonasheinrich	e34077144e	Adds a how to test all specs	9 years ago
jonasheinrich	3a0e0a336b	Merge pull request #3251 from ulferts/feature/bump_translations_to_4.2.2 bump translations to 4.2.2	9 years ago
Jens Ulferts	690d182100	bump translations to 4.2.2	9 years ago
Jens Ulferts	e415ccccb4	disable impossible test	9 years ago

1 2 3 4 5 ...

22281 Commits (6763fe875d3577d914854a93602594e72525e806) All Branches Search

22281 Commits (6763fe875d3577d914854a93602594e72525e806)

All Branches