Remove unnecessary uppercase check

pull/1470/head
Ardis Lu 2 years ago
parent 880f5a45ac
commit d4adca66da
No known key found for this signature in database
  1. 29
      slither/detectors/naming_convention/naming_convention.py

@ -119,22 +119,21 @@ Solidity defines a [naming convention](https://solidity.readthedocs.io/en/v0.4.2
for var in contract.state_variables_declared: for var in contract.state_variables_declared:
if self.should_avoid_name(var.name): if self.should_avoid_name(var.name):
if not self.is_upper_case_with_underscores(var.name): info = [
info = [ "Variable ",
"Variable ", var,
var, " used l, O, I, which should not be used\n",
" used l, O, I, which should not be used\n", ]
]
res = self.generate_result(info) res = self.generate_result(info)
res.add( res.add(
var, var,
{ {
"target": "variable", "target": "variable",
"convention": "l_O_I_should_not_be_used", "convention": "l_O_I_should_not_be_used",
}, },
) )
results.append(res) results.append(res)
if var.is_constant is True: if var.is_constant is True:
# For ERC20 compatibility # For ERC20 compatibility

Loading…
Cancel
Save