openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	b813e8b93f	Fix/bump gems (#9259 ) * bump aws-partitions * bump database_cleaner-active_record * bump rb-fsevent * bump recaptcha * bump sentry-ruby & sentry-ruby-core * bump terminal-table * bump date_validator * bump factory_bot & factory_bot_rails * avoid eager loading models via factories	4 years ago
OpenProject Actions CI	6108898fd5	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	8019c635ec	update locales from crowdin [ci skip]	4 years ago
ulferts	7f45901fcf	Fix/bump gems (#9197 ) * bump aws-partitions * bump aws-sdk-s3 * bump bindata * bump bootsnap * bump brakeman * bump deckar01-task_list * bump dry-logic * bump newrelic_rpm * bump octokit * bump aws-sdk-sns	4 years ago
OpenProject Actions CI	57aa62240e	update locales from crowdin [ci skip]	4 years ago
ulferts	d1f419385f	Feature/member custom notifications (#9173 ) * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
OpenProject Actions CI	3f34817f94	update locales from crowdin [ci skip]	4 years ago
OpenProject Actions CI	a723802985	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157 ) * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
ulferts	94fe889ba7	Fix/bump gems (#9106 ) * bump activerecord-session_store * bump oj * bump danger * bump rspec-rails * bump i18n-js * bump faker * bump aws-sdk-core * bump aws-sdk-kms * bump aws-sdk-s3 * bump aws-sdk-sns * bump icalendar	4 years ago
ulferts	a64c77c1be	avoid test flickering by having more complex password	4 years ago
ulferts	f0cf90d7e1	Fix the rails cell not using the content_tag helper of ActionView with escaping (#9067 ) * fixes show links for project members * Properly escapes the name. The cells gem does not escape strings unlike rails * Fixes the case statement for links and includes the link for placeholder users * Fix escaping of content_tag in rails cell and add spec for that Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	64cf18856b	Revert "update locales from crowdin [ci skip]" This reverts commit `3cb8fef5e6`.	4 years ago
Travis CI User	3cb8fef5e6	update locales from crowdin [ci skip]	4 years ago
ulferts	b5f016648e	bump aws-sdk-sns	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	78523a14f5	bump aws-sdk-sns	4 years ago
ulferts	b536309a57	fix flickering spec by not providing a weak password	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Travis CI User	1093bb1181	update locales from crowdin [ci skip]	4 years ago
Travis CI User	1b5f100fe1	update locales from crowdin [ci skip]	4 years ago
Travis CI User	a013096cd0	update locales from crowdin [ci skip]	4 years ago
Travis CI User	53cf33603c	update locales from crowdin [ci skip]	4 years ago
ulferts	26295af6bd	Chore/replace activemodel mocks (#8892 ) * replace stub_model calls * replace mock_model * remove rspec-activemodel-mocks dependency	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	1e53c4f2fa	Fix/bump gems (#8850 ) * bump webmock * bump rubocop * bump listen * bump grape * bump erubi * bump airbrake-ruby * bump aws-sdk-sns * bump parallel_tests * bump aws-partitions * bump aws-sdk-core * attempt to stabilize flickering spec	4 years ago
ulferts	c7840f7cf5	Fix/bump gems (#8839 ) * bump webmock * bump rubocop * bump aws-sdk-s3 * bump aws-sdk-sns * bump bootsnap * bump danger * bump listen * bump oj * bump tzinfo * bump rouge * bump sys-filesystem	4 years ago
Travis CI User	37a75fe599	update locales from crowdin [ci skip]	4 years ago
Travis CI User	54a0d3c621	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b27abc2999	update locales from crowdin [ci skip]	4 years ago
Travis CI User	398ea7a764	update locales from crowdin [ci skip]	4 years ago
Travis CI User	17f1f3c39c	update locales from crowdin [ci skip]	4 years ago
Travis CI User	cbf001a21f	update locales from crowdin [ci skip]	4 years ago
Travis CI User	49ef82d776	update locales from crowdin [ci skip]	4 years ago
ulferts	27b41a313c	replace custom i18n function in views	4 years ago
ulferts	d695d03411	Fix/plugin settings breadcrumb label (#8618 ) * simplify code now that i18n can handle defaults * standardize settings plural i18n key * remove unused variable	4 years ago
ulferts	6947a963d2	bump rotp	4 years ago
ulferts	9a929504c9	bump aws-sdk-sns	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Travis CI User	2af5a6f724	update locales from crowdin [ci skip]	4 years ago
Travis CI User	28d693eb9c	update locales from crowdin [ci skip]	4 years ago
Travis CI User	9380afba86	update locales from crowdin [ci skip]	4 years ago
Travis CI User	38461db72b	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	10e21154f7	Move asset pipeline javascripts to frontend (#8482 ) * ove reporting and reporting_engine js to frontend page * Replace webhook assets javascript * Add path augment service to dynamically load scripts * Remove JS-Files that are not used/not needed any more * Include AugmentingModule correctly * Remove special handling for checkbox selection which is outdated and two jquery libs that are not used any more * Load scripts dynamically that are not needed globally * Move plugin JS to frontend * Move toggable fieldsets to global listeners * Move top-menu to global listeners and convert to TS * Move action_menu to frontend and port to TS * Move settings listener to frontend * Remove global js assets that were not used anyway * Move date range to timelog dynamic script where it's still used until removed * Move colors to global-listeners and port to TS * Replace tooltip with simple form instructions on the one place used Tooltips were only used at the one place in our application, when changing a users password. We can simply remove it there and use a modern solution the next time we need a tooltip * Move danger zone validation to frontend and port to TS * Move colorcontrast to backlogs vendor where it's used now * Remove contents of application.js.erb * Move project and user scripts to dynamically loaded * Move onboarding tour to dynamically loaded * Use correct syntax for jQuery so that $ is known keyword within this function * Fix onboarding tour * Fix onboarding tour for scrum tour * Fix specs after moving JS * Remove application.js.erb * Move locales and ckeditor to the frontend to dynamically load * Remove bundles caches These are no longer being used since angular cli * Ensure locales are exported before angular Co-authored-by: Henriette Darge <h.darge@openproject.com>	4 years ago
Travis CI User	c1bda74a27	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b2f828d949	update locales from crowdin [ci skip]	4 years ago
Travis CI User	6fd3454b56	update locales from crowdin [ci skip]	4 years ago

1 2 3

123 Commits (a021379a983727a68230951084bc39812b9b4d75)