248 Commits (bbeae32698337c2cb5a544df25ff1a64a056af7c)

Author	SHA1	Message	Date
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Travis CI User	a43bf4a589	update locales from crowdin [ci skip]	4 years ago
Travis CI User	888e802e1e	update locales from crowdin [ci skip]	4 years ago
Travis CI User	6453157ad5	update locales from crowdin [ci skip]	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	655f021b92	add derived dates to the work package resource ... The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
Oliver Günther	dfa6bdb456	Extract all access of APIv3 calls into APIv3Service (#8521) ... * Move apiv3 path helper into apiv3 service * Refactor application to use apiv3 service * Allow caching responses within apiv3 endpoints through state cache * Fix reference to root service * Continue refactoring of DM services * Refactor version DM service * Refactor order service into v3 paths * Replace time entry dm and cache service * Replace QueryFormDmService with nested form resource * Replace QueryDmService with api paths * Replace ProjectDM and ProjectCacheService * Move PayloadDmService into static helper class * Replace NewsDmService with api paths * Replace MembershipDmService with api paths * Replace HelpTextDmService with api paths * Replace ConfigurationDmService with apiv3 path * Replace GridDmService with paths * Remove DmListParameters This is now Apiv3ListParameters type * Replace virtual BoardDmService with a virtual path Boards are not actually their own API resource, but a shallow wrapper over a grid resource. To reuse the same API service pattern, we can allow other resources other than HalResource and make the boards path just reference the grids paths. This allows to nicely use the `apiV3Service.boards.id(..).cache` patterns. * Refactor cacheState into single method * Make HalEditingService a v3 cache without loading ability * Replace usages of WorkPackageCacheService with api-integrated cache * Fix accessing grid subpath * Correctly use schema ensureLoaded before inserting into caches * Fix query not having an ID when updating * Fix npm tests after removal of wp cache * Readd missing path helper for APIv3 used from ckeditor * Correctly save query in widget * Fix watcher tab * Fix search path * Use a promise for the updateImmediately link of time entry * Make apiv3 independent cache services depend on the base cache service We had two cache services now, one base service for the apiv3, and the previous one. Both shared a lot of code, so we can unify them * Don't use multiState getter in schemaCache * Correct loading of schema * Correctly fill state with relations * Don't render comment until workPackage ready * Merge the initial loading observable to get error handling If we only return state.values$(), we never get the initial http observable and thus no error handling * Ensure we reload the default query from the current project if any * Use get() instead of stream * Load types correctly * Fix paths in enterprise token urls * Ensure take(1) in requireAndStream toPromise usage * Avoid duplicate StateCacheService definition * Only use project based query when there is no query.id yet There is no endpoint for /api/v3/projects/:projectIdentifier/queries/:id * Add isAvailable to filter out filters incorrectly added The search component always adds a subproject filter when in project scope. This filter however is only valid/existent in schemas if there is a subproject. This ensures we only try to access filters that are available * Refactor embedded table to reuse the loadQueryFromExisting method We had a few duplicate methods on how to look for a query with params basing on an existing (saved or unsaved) query. * Ensure filter schemas are inserted and checked before use * Better matcher for search spec * Ensure correct initialization of query states * Load attribute help text correctly	4 years ago
Oliver Günther	7e185a8ca1	Don't use id=1 for an entry that might still exist ... [ci skip]	4 years ago
Travis CI User	c1bda74a27	update locales from crowdin [ci skip]	4 years ago
Travis CI User	b2f828d949	update locales from crowdin [ci skip]	4 years ago
Travis CI User	6fd3454b56	update locales from crowdin [ci skip]	4 years ago
Travis CI User	afcf2d2afb	update locales from crowdin [ci skip]	4 years ago
Oliver Günther	623f8c772e	Move module assets to frontend	4 years ago
Travis CI User	ecef114310	update locales from crowdin [ci skip]	4 years ago
Travis CI User	55c237d358	update locales from crowdin [ci skip]	4 years ago
Henriette Darge	8b3bae8bbb	Remove wrong/outdated usage of "box" class and adapt HTML structure to LSG at these places	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410) ... * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Travis CI User	7cafc0b850	update locales from crowdin [ci skip]	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Travis CI User	59da7cbd3c	update locales from crowdin [ci skip]	5 years ago
Henriette Darge	ebc3f6fe18	Prevent that the backend changes the order of filter attributes (sorted by id). Otherwise there is a visible change in the filter attributes in the frontend.	5 years ago
Travis CI User	2e256157f9	update locales from crowdin [ci skip]	5 years ago
Travis CI User	1c925cbd57	update locales from crowdin [ci skip]	5 years ago
Henriette Darge	a61bcc7132	Rename cost reports module && Correct author_urls	5 years ago
Travis CI User	f782113a05	update locales from crowdin [ci skip]	5 years ago
ulferts	45250f94bf	fix reference to method	5 years ago
Travis CI User	1422c0cea5	update locales from crowdin [ci skip]	5 years ago
Travis CI User	f05e3f797a	update locales from crowdin [ci skip]	5 years ago
bsatarnejad	e1a11a4839	make a whole container	5 years ago
bsatarnejad	c4c2b6a2f9	add space below each user history rate box	5 years ago
Travis CI User	040515f8bf	update locales from crowdin [ci skip]	5 years ago
Travis CI User	30ac5e5785	update locales from crowdin [ci skip]	5 years ago
Travis CI User	4425947e29	update locales from crowdin [ci skip]	5 years ago
Travis CI User	af35d1c65e	update locales from crowdin [ci skip]	5 years ago
Travis CI User	9499abe992	update locales from crowdin [ci skip]	5 years ago
Travis CI User	5f00897815	update locales from crowdin [ci skip]	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
Oliver Günther	812cbf183c	Allow filters to define multiple LDAP synchronized groups	5 years ago
Travis CI User	3af2d52aaf	update locales from crowdin [ci skip]	5 years ago
Travis CI User	1569c67af6	update locales from crowdin [ci skip]	5 years ago
Travis CI User	525c1eb518	update locales from crowdin [ci skip]	5 years ago
Travis CI User	8470e31dee	update locales from crowdin [ci skip]	5 years ago
Travis CI User	acc8f7dacf	update locales from crowdin [ci skip]	5 years ago
Travis CI User	61ee67427a	update locales from crowdin [ci skip]	5 years ago
Travis CI User	83cc9263be	update locales from crowdin [ci skip]	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	6ded4e6852	Add cron job functionality to delayed_job	5 years ago
ulferts	3f9126a9e8	remove/replace/reactivate specs disabled by former plugins	5 years ago
ulferts	8727e40b0e	expand tests for non editing and custom budget case	5 years ago